-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ACM modules #1263
Merged
softwarefactory-project-zuul
merged 3 commits into
ansible-collections:main
from
tremble:renames/acm_certificate
Jun 25, 2022
Merged
Rename ACM modules #1263
softwarefactory-project-zuul
merged 3 commits into
ansible-collections:main
from
tremble:renames/acm_certificate
Jun 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
community_review
docs
feature
This issue/PR relates to a feature request
integration
tests/integration
module
module
needs_triage
new_module
New module
new_plugin
New plugin
plugins
plugin (any type)
tests
tests
labels
Jun 25, 2022
This comment was marked as resolved.
This comment was marked as resolved.
markuman
approved these changes
Jun 25, 2022
This comment was marked as outdated.
This comment was marked as outdated.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
docs
feature
This issue/PR relates to a feature request
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
new_module
New module
new_plugin
New plugin
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In line with what I understood to be the consensus on ansible-collections/amazon.aws#881 and ansible-collections/amazon.aws#610
Rename aws_acm to acm_certificate
Rename aws_acm_info to acm_certificate_info
ISSUE TYPE
COMPONENT NAME
aws_acm
aws_acm_info
acm_certificate
acm_certificate_info
ADDITIONAL INFORMATION