Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename batch modules #1272

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 28, 2022

SUMMARY

In line with the naming guidelines, removes the aws_ prefix from aws_batch_compute_environment, aws_batch_job_definition and aws_batch_job_queue.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/aws_batch_compute_environment.py
plugins/modules/aws_batch_job_definition.py
plugins/modules/aws_batch_job_queue.py
plugins/modules/batch_compute_environment.py
plugins/modules/batch_job_definition.py
plugins/modules/batch_job_queue.py

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs feature This issue/PR relates to a feature request module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) labels Jun 28, 2022
@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 10s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 58s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 39s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 27s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 33s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 44s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 11s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 43s
✔️ ansible-test-splitter SUCCESS in 2m 57s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble requested a review from jatorcasso June 28, 2022 18:29
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 14s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 00s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 39s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 24s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 29s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 50s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 52s
✔️ ansible-test-splitter SUCCESS in 2m 42s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 081cd7b into ansible-collections:main Jun 28, 2022
@tremble tremble deleted the renames/batch branch July 7, 2022 19:25
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…llections#1272)

ec2_snapshot/tests: wait until the snapshots are available

Until this patch we were unconditionally waiting 3 minutes. We now query the
status until we've got our 5 snapshots available.
This will resolve failure like this one:
See: https://ansible.softwarefactory-project.io/zuul/build/e49e7dc231ac4f5990bb6c231096ded8

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants