Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename api_gateway modules #1288

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 30, 2022

SUMMARY

In line with the naming guidelines, removes the aws_ prefix from aws_api_gateway and aws_api_gateway_domain.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/aws_api_gateway.py
plugins/modules/aws_api_gateway_domain.py
plugins/modules/api_gateway.py
plugins/modules/api_gateway_domain.py

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jun 30, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jun 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 5m 20s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 49s
ansible-test-sanity-docker-devel FAILURE in 10m 57s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 57s
ansible-test-sanity-docker-stable-2.12 FAILURE in 11m 22s
ansible-test-sanity-docker-stable-2.13 FAILURE in 11m 15s
ansible-test-units-community-aws-python38 FAILURE in 6m 43s
ansible-test-units-community-aws-python39 FAILURE in 6m 31s
✔️ ansible-test-splitter SUCCESS in 2m 49s
✔️ integration-community.aws-1 SUCCESS in 8m 58s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble
Copy link
Contributor Author

tremble commented Jun 30, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 05s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 38s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 21s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 09s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 51s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 14s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 33s
✔️ ansible-test-splitter SUCCESS in 2m 46s
✔️ integration-community.aws-1 SUCCESS in 9m 33s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 33s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 18s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 08s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 57s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 59s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 08s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 15s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 14s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-community.aws-1 SUCCESS in 9m 50s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2caa275 into ansible-collections:main Jun 30, 2022
@tremble tremble deleted the renames/apigateway branch July 7, 2022 19:22
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ec2_key/tests: add unit-tests 

SUMMARY


Add the unit-test coverage of the ec2_key module.
Refactor the module to reduce complexity and allow unit testing.


COMPONENT NAME

ec2_key
Latest unit-test coverage (86%): https://890cb34819f4a5031a6a-ac7bf798a2c5290001623a42300937df.ssl.cf5.rackcdn.com/1288/8f1100d82dc058131d0476ff7f82ee7f6eac5b7b/check/cloud-tox-py3/8b0e4b4/docs/coverage/plugins_modules_ec2_key_py.html

Reviewed-by: Mark Chappell <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants