Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AWS config modules #1305

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 4, 2022

SUMMARY

Rename various aws_config modules in line with the naming guidelines (remove the aws_ prefix)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/aws_config_aggregation_authorization.py
plugins/modules/config_aggregation_authorization.py
plugins/modules/aws_config_aggregator.py
plugins/modules/config_aggregator.py
plugins/modules/aws_config_delivery_channel.py
plugins/modules/config_delivery_channel.py
plugins/modules/aws_config_recorder.py
plugins/modules/config_recorder.py
plugins/modules/aws_config_rule.py
plugins/modules/config_rule.py

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jul 4, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 03s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 42s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 36s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 05s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 42s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 9m 16s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 38s
✔️ ansible-test-splitter SUCCESS in 2m 35s
✔️ integration-community.aws-1 SUCCESS in 6m 35s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 4, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 03s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 06s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 34s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 53s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 43s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 34s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 52s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 29s
✔️ ansible-test-splitter SUCCESS in 2m 59s
✔️ integration-community.aws-1 SUCCESS in 5m 03s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 753bc89 into ansible-collections:main Jul 4, 2022
@tremble tremble deleted the renames/config branch July 7, 2022 19:22
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…g objects (ansible-collections#1307)

Add support to _boto3_conn for dicts as well as botocore.config.Config objects

SUMMARY
Working on ansible-collections#1305 I hit really weird issues passing "config" in as a dictionary (elsewhere we would pass a dict about rather than something as unique as a botocore.config.Config object).
Add support for passing a dict rather than a full blown Config object, this reduces the number of places that need to know about the inner workings of botocore.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Refactor S3 connection code 

SUMMARY
Builds upon ansible-collections#1303 making the S3 code closer to the rest of our connection code.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_object
s3_object_info
s3_bucket
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants