ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1331

tremble · 2022-07-09T09:49:04Z

SUMMARY

fixes: #137

ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

plugins/modules/ec2_vpc_vgw_info.py

ADDITIONAL INFORMATION

ansibullbot · 2022-07-09T09:49:58Z

cc @jillr @markuman @naslanidis @s-hertel
click here for bot help

github-actions · 2022-07-09T09:53:43Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2022-07-09T10:08:21Z

Build succeeded.

jatorcasso · 2022-07-09T19:55:16Z

I know this should be backported to 3 & 4, but not sure about others so ill let you add those labels

softwarefactory-project-zuul · 2022-07-09T20:14:52Z

Build succeeded (gate pipeline).

patchback · 2022-07-09T20:14:57Z

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply ed4165d on top of patchback/backports/stable-3/ed4165d6e34c5c33c751c8b138f24a058d1c2b6e/pr-1331

Backporting merged PR #1331 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/community.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-3/ed4165d6e34c5c33c751c8b138f24a058d1c2b6e/pr-1331 upstream/stable-3

Now, cherry-pick PR ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1331 contents into that branch:
```
$ git cherry-pick -x ed4165d6e34c5c33c751c8b138f24a058d1c2b6e
```
If it'll yell at you with something like fatal: Commit ed4165d6e34c5c33c751c8b138f24a058d1c2b6e is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x ed4165d6e34c5c33c751c8b138f24a058d1c2b6e
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1331 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-3/ed4165d6e34c5c33c751c8b138f24a058d1c2b6e/pr-1331

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2022-07-09T20:15:02Z

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/ed4165d6e34c5c33c751c8b138f24a058d1c2b6e/pr-1331

Backported as #1336

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

#1331) ec2_vpc_vgw_info - update to not throw an error when run in check_mode SUMMARY fixes: #137 ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_vpc_vgw_info.py ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> (cherry picked from commit ed4165d)

#1331) (#1336) [PR #1331/ed4165d6 backport][stable-4] ec2_vpc_vgw_info - update to not throw an error when run in check_mode This is a backport of PR #1331 as merged into main (ed4165d). SUMMARY fixes: #137 ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_vpc_vgw_info.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>

ec2_vpc_vgw_info - update to not throw an error when run in check_mode

0f20db1

tremble requested review from markuman, jatorcasso and alinabuzachis July 9, 2022 09:49

ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jul 9, 2022

jatorcasso approved these changes Jul 9, 2022

View reviewed changes

jatorcasso added backport-4 PR should be backported to the stable-4 branch backport-3 PR should be backported to the stable-3 branch labels Jul 9, 2022

tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 9, 2022

softwarefactory-project-zuul bot merged commit ed4165d into ansible-collections:main Jul 9, 2022

patchback bot mentioned this pull request Jul 9, 2022

[PR #1331/ed4165d6 backport][stable-4] ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1336

Merged

tremble deleted the issue/137 branch September 9, 2022 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1331

ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1331

tremble commented Jul 9, 2022

ansibullbot commented Jul 9, 2022

github-actions bot commented Jul 9, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Jul 9, 2022

jatorcasso commented Jul 9, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Jul 9, 2022

patchback bot commented Jul 9, 2022 •

edited

Loading

patchback bot commented Jul 9, 2022 •

edited

Loading

ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1331

ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1331

Conversation

tremble commented Jul 9, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jul 9, 2022

github-actions bot commented Jul 9, 2022 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Jul 9, 2022

jatorcasso commented Jul 9, 2022 • edited Loading

softwarefactory-project-zuul bot commented Jul 9, 2022

patchback bot commented Jul 9, 2022 • edited Loading

Backport to stable-3: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1331 into main

patchback bot commented Jul 9, 2022 • edited Loading

Backport to stable-4: 💚 backport PR created

github-actions bot commented Jul 9, 2022 •

edited

Loading

jatorcasso commented Jul 9, 2022 •

edited

Loading

patchback bot commented Jul 9, 2022 •

edited

Loading

patchback bot commented Jul 9, 2022 •

edited

Loading