Re-enable integration tests for elb_network_lb #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
|
This change depends on a change that failed to merge. |
This comment was marked as outdated.
This comment was marked as outdated.
jatorcasso
reviewed
Jul 21, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
approved these changes
Jul 22, 2022
tremble
commented
Jul 22, 2022
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Jul 22, 2022
More work on ELBv2 module_utils SUMMARY Refactors LB creation and makes sure that ip_address_type is set on creation (bug found when working on fixing NLB tests) Fixes bug with DefaultAction comparisons Extends tests for _prune_ForwardConfig Extends tests for _prune_secrets Fixes KeyError bug uncovered when extending tests for _prune_secrets ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/elbv2.py ADDITIONAL INFORMATION Fixes: ansible-collections/community.aws#604 See also: ansible-collections/community.aws#1365 Reviewed-by: Alina Buzachis <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible-collections/amazon.aws#940
SUMMARY
ip_address_typein return value wasn't updatedISSUE TYPE
COMPONENT NAME
tests/integration/targets/elb_network_lb
ADDITIONAL INFORMATION