Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated AWSRetry.backoff usage #1386

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 2, 2022

Depends-On: ansible-collections/amazon.aws#946

SUMMARY

AWSRetry.backoff was deprecated (and originally slated for removal in 4.0.0) remove usage.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

acm_certificate_info
acm_certificate
api_gateway_domain
waf_condition
waf_info
waf_rule
waf_web_acl

ADDITIONAL INFORMATION

WAF and ACM changes are coming from amazon.aws (linked PR), this just drops in a changelog fragment

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@tremble This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Aug 2, 2022
@tremble tremble changed the title Remove deprecated @AWSRetry.backoff usage Remove deprecated AWSRetry.backoff usage Aug 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 36s
✔️ build-ansible-collection SUCCESS in 5m 10s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 23s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 35s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 05s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 37s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 02s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 22m 44s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 3, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 5m 11s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 02s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 38s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 26s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 8m 14s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 38s
✔️ ansible-test-splitter SUCCESS in 2m 37s
✔️ integration-community.aws-1 SUCCESS in 17m 36s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f5efd47 into ansible-collections:main Aug 3, 2022
@tremble tremble deleted the retries branch September 9, 2022 09:03
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Minor fixups to release docs

SUMMARY
Using "Minor and Patch releases" as an internal reference caused antsibull to drop the file on the floor because it wasn't in the right namespace
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
docs/docsite/rst/collection_release.rst
ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants