tests/autoscaling_{group,lifecycle_hook}: use setup_ec2_facts #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
integration
|
It would be better to reuse the AMI from setup_ec2_facts if we can... |
goneri
changed the title
goneri
changed the title
|
recheck |
goneri
force-pushed
the
tests-autoscaling_lifecycle_hook-bump-the-instance-image_858
branch
from
cc9cf55
to
afbdd28
Compare
`amzn2-ami-hvm-2.0.20190612-x86_64-gp2` is not available anymore, we now use `setup_ec2_facts` to get the right AMI ID.
goneri
force-pushed
the
tests-autoscaling_lifecycle_hook-bump-the-instance-image_858
branch
from
afbdd28
to
4b8f0a5
Compare
|
This change depends on a change that failed to merge. |
|
recheck |
This was referenced Sep 14, 2022
tremble
approved these changes
Sep 16, 2022
|
Pull request merge failed: Required status check "ansible/gate" is expected. |
|
@goneri this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
…#1467) tests/integration: ensure the CI gives more time to some slow targets Depends-On: ansible/ansible-zuul-jobs#1625 Depends-On: #1468 Depends-On: #1473 Reviewed-by: Mark Chappell <None>
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1499 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
tests/autoscaling_{group,lifecycle_hook}: use setup_ec2_facts
amzn2-ami-hvm-2.0.20190612-x86_64-gp2 is not available anymore, we now use setup_ec2_facts to get the right AMI ID.
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 1cd7ceb)
tremble
pushed a commit
to tremble/community.aws
that referenced
this pull request
Sep 19, 2022
…e-collections#1468) tests/autoscaling_{group,lifecycle_hook}: use setup_ec2_facts amzn2-ami-hvm-2.0.20190612-x86_64-gp2 is not available anymore, we now use setup_ec2_facts to get the right AMI ID. Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
…ycle_hook}: use setup_ec2_facts (#1499) [PR #1468/1cd7cebb backport][stable-4] tests/autoscaling_{group,lifecycle_hook}: use setup_ec2_facts This is a backport of PR #1468 as merged into main (1cd7ceb). amzn2-ami-hvm-2.0.20190612-x86_64-gp2 is not available anymore, we now use setup_ec2_facts to get the right AMI ID. Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
…#1500) [PR #1468/1cd7cebb backport][stable-3] tests/autoscaling_{group,lifecycle_hook}: use setup_ec2_facts amzn2-ami-hvm-2.0.20190612-x86_64-gp2 is not available anymore, we now use setup_ec2_facts to get the right AMI ID. Reviewed-by: Mark Chappell SUMMARY Partial backport of #1468 (lifecycle hooks didn't exist in stable-3) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/ec2_asg ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…e-collections#1468) tests/autoscaling_{group,lifecycle_hook}: use setup_ec2_facts amzn2-ami-hvm-2.0.20190612-x86_64-gp2 is not available anymore, we now use setup_ec2_facts to get the right AMI ID. Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@1cd7ceb
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Pick up app_callback -> set_password rather than app_callback -> set_passwd SUMMARY Closes: ansible-collections#1449 Pick up app_callback -> set_password rather than app_callback -> set_passwd ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amzn2-ami-hvm-2.0.20190612-x86_64-gp2is not available anymore, we now usesetup_ec2_factsto get the right AMI ID.