Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticache): support for redis6.x group family for parameter groups #1476

Merged
merged 7 commits into from
Nov 15, 2022
Merged

feat(elasticache): support for redis6.x group family for parameter groups #1476

merged 7 commits into from
Nov 15, 2022

Conversation

MadJlzz
Copy link
Contributor

@MadJlzz MadJlzz commented Sep 16, 2022

SUMMARY

AWS cache parameters groups can now be of type redis6.x. This PR adds to the module elasticache_parameter_group support to pass this new family group.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Impacted component: elasticache_parameter_group module.

@github-actions
Copy link

github-actions bot commented Sep 16, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Sep 16, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 5m 32s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 05s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 32s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 45s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 9m 01s
✔️ ansible-test-splitter SUCCESS in 2m 50s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED

@markuman
Copy link
Member

@MadJlzz can you also please add a changelog fragment?
https://docs.ansible.com/ansible/latest/community/development_process.html#creating-changelog-fragments

otherwise LGTM.

@markuman markuman added backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch labels Sep 28, 2022
@MadJlzz
Copy link
Contributor Author

MadJlzz commented Sep 28, 2022

Thanks @markuman! WDYT of the changelog?

@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

@markuman
Copy link
Member

recheck

@markuman
Copy link
Member

oh.

ERROR: changelogs/fragments/1476-add-redis6x-cache-parameter-group-family:0:0: extension must be one of: .yml, .yaml

@MadJlzz git mv changelogs/fragments/1476-add-redis6x-cache-parameter-group-family changelogs/fragments/1476-add-redis6x-cache-parameter-group-family.yml

@softwarefactory-project-zuul
Copy link
Contributor

@MadJlzz
Copy link
Contributor Author

MadJlzz commented Sep 29, 2022

@markuman sorry about that. File is renamed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 33s
✔️ build-ansible-collection SUCCESS in 6m 06s
ansible-test-sanity-docker-devel FAILURE in 9m 13s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 26s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 06s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 55s
ansible-test-sanity-docker-stable-2.14 FAILURE in 10m 09s (non-voting)
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 26s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 32s
✔️ ansible-test-splitter SUCCESS in 2m 34s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Oct 5, 2022
@goneri
Copy link
Member

goneri commented Oct 5, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 5m 33s
ansible-test-sanity-docker-devel FAILURE in 12m 01s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 49s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 33s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 37s
ansible-test-sanity-docker-stable-2.14 FAILURE in 11m 08s (non-voting)
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 35s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 12s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 59s
✔️ ansible-test-splitter SUCCESS in 2m 34s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED

@markuman markuman added backport-5 PR should be backported to the stable-5 branch and removed backport-3 PR should be backported to the stable-3 branch labels Oct 18, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 30s
✔️ build-ansible-collection SUCCESS in 4m 57s
ansible-test-sanity-docker-devel FAILURE in 9m 42s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 24s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 19s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 05s
ansible-test-sanity-docker-stable-2.14 FAILURE in 10m 16s (non-voting)
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 10s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 02s
✔️ ansible-test-splitter SUCCESS in 2m 39s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 16s

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Nov 15, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 5m 01s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 51s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 8m 43s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 50s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 54s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 31s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 07s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 23s
✔️ ansible-test-changelog SUCCESS in 2m 19s
✔️ ansible-test-splitter SUCCESS in 2m 25s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 784669d into ansible-collections:main Nov 15, 2022
@patchback
Copy link

patchback bot commented Nov 15, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/784669d2b856518209fdd1e4aca58eed6eb49ba2/pr-1476

Backported as #1594

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 15, 2022
…oups (#1476)

feat(elasticache): support for redis6.x group family for parameter groups

SUMMARY
AWS cache parameters groups can now be of type redis6.x. This PR adds to the module elasticache_parameter_group support to pass this new family group.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Impacted component: elasticache_parameter_group module.

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Felix Fontein <[email protected]>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 784669d)
@patchback
Copy link

patchback bot commented Nov 15, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/784669d2b856518209fdd1e4aca58eed6eb49ba2/pr-1476

Backported as #1595

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 15, 2022
…oups (#1476)

feat(elasticache): support for redis6.x group family for parameter groups

SUMMARY
AWS cache parameters groups can now be of type redis6.x. This PR adds to the module elasticache_parameter_group support to pass this new family group.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Impacted component: elasticache_parameter_group module.

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Felix Fontein <[email protected]>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 784669d)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 2, 2022
…oups (#1476) (#1594)

[PR #1476/784669d2 backport][stable-4] feat(elasticache): support for redis6.x group family for parameter groups

This is a backport of PR #1476 as merged into main (784669d).
SUMMARY
AWS cache parameters groups can now be of type redis6.x. This PR adds to the module elasticache_parameter_group support to pass this new family group.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Impacted component: elasticache_parameter_group module.

Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 2, 2022
…oups (#1476) (#1595)

[PR #1476/784669d2 backport][stable-5] feat(elasticache): support for redis6.x group family for parameter groups

This is a backport of PR #1476 as merged into main (784669d).
SUMMARY
AWS cache parameters groups can now be of type redis6.x. This PR adds to the module elasticache_parameter_group support to pass this new family group.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Impacted component: elasticache_parameter_group module.

Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants