Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_placement_group: Handle a potential race creation during create #1477

Conversation

goneri
Copy link
Member

@goneri goneri commented Sep 16, 2022

Address a race condition during the creation of a new Placement Group.
The consequence was a "placement_group": null in output after a
successful new creation.

e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt

Address a race condition during the creation of a new Placement Group.
The consequence was a `"placement_group": null` in output after a
successful new creation.

e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt
@goneri goneri force-pushed the ec2_placement_group-Handle-a-potential-race-creation-during-create_7036 branch from 31318c4 to fe3a568 Compare September 16, 2022 13:51
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 40s
✔️ build-ansible-collection SUCCESS in 6m 22s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 55s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 13m 37s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 43s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 02s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 09s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 8m 51s
✔️ ansible-test-splitter SUCCESS in 2m 40s
✔️ integration-community.aws-1 SUCCESS in 11m 38s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED

@tremble tremble added mergeit Merge the PR (SoftwareFactory) backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch labels Sep 16, 2022
@ansibullbot
Copy link

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 5m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 10s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 17s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 20s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 22s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 43s
✔️ ansible-test-splitter SUCCESS in 2m 43s
✔️ integration-community.aws-1 SUCCESS in 7m 23s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Required status check "ansible/gate" is expected.

@goneri
Copy link
Member Author

goneri commented Sep 16, 2022

regate

@ansibullbot
Copy link

@goneri this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review labels Sep 16, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 4m 57s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 23s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 17s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 19s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 53s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 02s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 46s
✔️ ansible-test-splitter SUCCESS in 3m 17s
✔️ integration-community.aws-1 SUCCESS in 6m 59s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d4eb13b into ansible-collections:main Sep 16, 2022
@patchback
Copy link

patchback bot commented Sep 16, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/d4eb13b1041872e3d88d1f15beaf055ff38c0a25/pr-1477

Backported as #1492

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 16, 2022
…1477)

ec2_placement_group: Handle a potential race creation during create

Address a race condition during the creation of a new Placement Group.
The consequence was a "placement_group": null in output after a
successful new creation.
e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt

Reviewed-by: Mark Chappell <None>
(cherry picked from commit d4eb13b)
@patchback
Copy link

patchback bot commented Sep 16, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/d4eb13b1041872e3d88d1f15beaf055ff38c0a25/pr-1477

Backported as #1493

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 16, 2022
…1477)

ec2_placement_group: Handle a potential race creation during create

Address a race condition during the creation of a new Placement Group.
The consequence was a "placement_group": null in output after a
successful new creation.
e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt

Reviewed-by: Mark Chappell <None>
(cherry picked from commit d4eb13b)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 19, 2022
…1477) (#1492)

[PR #1477/d4eb13b1 backport][stable-3] ec2_placement_group: Handle a potential race creation during create

This is a backport of PR #1477 as merged into main (d4eb13b).
Address a race condition during the creation of a new Placement Group.
The consequence was a "placement_group": null in output after a
successful new creation.
e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 19, 2022
…1477) (#1493)

[PR #1477/d4eb13b1 backport][stable-4] ec2_placement_group: Handle a potential race creation during create

This is a backport of PR #1477 as merged into main (d4eb13b).
Address a race condition during the creation of a new Placement Group.
The consequence was a "placement_group": null in output after a
successful new creation.
e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…1477)

elbv2 - Drop tests for ancient botocore (not supported)

SUMMARY
Remove compat code for old botocore versions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
module_utils/elbv2
ADDITIONAL INFORMATION
We dropped support for botocore 1.10.30 a couple of years ago.

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch merge_commit This PR contains at least one merge commit. Please resolve! mergeit Merge the PR (SoftwareFactory) module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants