elb_target_group: Add support for protocol_version parameter #1496
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
|
... @sharvarikhedkar thank you for the PR. |
changelogs/fragments/1496-elb_target_group-add-protocol_version-support.yml
Outdated
Show resolved
Hide resolved
sharvarikhedkar
requested review from
markuman and
goneri
and removed request for
goneri and
markuman
markuman
added
backport-5
| - name: Create a target group with protocol_version 'GRPC' (idempotence) | ||
| community.aws.elb_target_group: | ||
| name: "{{ elb_target_group_name }}" | ||
| protocol: http | ||
| port: 80 | ||
| vpc_id: "{{ vpc.vpc.id }}" | ||
| protocol_version: GRPC | ||
| state: present | ||
| register: create_result | ||
|
|
||
| - assert: | ||
| that: | ||
| - create_result is not changed | ||
| - create_result is not failed | ||
| - create_result.protocol_version == "GRPC" | ||
| - create_result.protocol == "HTTP" | ||
| - create_result.port == 80 |
There was a problem hiding this comment.
@sharvarikhedkar can you also please a third test that verify that a change of the protocol_version works properly?
There was a problem hiding this comment.
Hi @markuman, I tried testing the code for updating the target group with different protocol_versions but looking at the boto3 documentation and trying to modify protocol_version through AWS console, it seems like the update operation for protocol_version parameter is not supported yet, any insights on this?
There was a problem hiding this comment.
Oh, I didn't know that. Maybe that should be mentioned than in the module documentation @sharvarikhedkar
|
recheck |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1577 🤖 @patchback |
elb_target_group: Add support for protocol_version parameter SUMMARY Added support for protocol_version param in elb_target_group. Fixes 1422. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Sharvari Khedkar <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 02bbc54)
…1577) [PR #1496/02bbc544 backport][stable-5] elb_target_group: Add support for protocol_version parameter This is a backport of PR #1496 as merged into main (02bbc54). SUMMARY Added support for protocol_version param in elb_target_group. Fixes 1422. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group Reviewed-by: Markus Bergholz <[email protected]>
SUMMARY
Added support for
protocol_versionparam inelb_target_group.Fixes 1422.
ISSUE TYPE
COMPONENT NAME
elb_target_group