eks_cluster: adding tags to eks cluster #1591
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
|
@goneri please have look |
|
Hi @mohgho, Thank you for the Pull Request. Can you modify this task to also set a tag? https://github.com/ansible-collections/community.aws/blob/main/tests/integration/targets/eks_cluster/tasks/full_test.yml#L77-L83 Also, we will need a new changelog fragment in https://github.com/ansible-collections/community.aws/tree/main/changelogs/fragments to describe the bug fix. This way, your change will be included in the next release changelog. |
|
Hi @goneri |
Next version is actually 5.2.0, my bad.
|
recheck |
|
Hi @mohgho, Many thanks for taking the time to open this PR. Sorry it took a while to get this merged. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1699 🤖 @patchback |
eks_cluster: adding tags to eks cluster SUMMARY As described by issue #1513 All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_eks_cluster ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Amir <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 3c1c903)
[PR #1591/3c1c903a backport][stable-5] eks_cluster: adding tags to eks cluster This is a backport of PR #1591 as merged into main (3c1c903). SUMMARY As described by issue #1513 All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_eks_cluster ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
SUMMARY
As described by issue #1513
All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console.
ISSUE TYPE
COMPONENT NAME
aws_eks_cluster
ADDITIONAL INFORMATION