Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. #1633

adsanz · 2022-12-30T13:48:29Z

SUMMARY

Added the chance of setting up the addressing style for S3 URLs, this fixes #637

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

aws_ssm

ADDITIONAL INFORMATION

I came across this issue when I was trying to connect and execute tasks on a fresh AWS set-up (new S3 bucket + EC2), I'm using the latest (5.1.0) release and Ansible 5.10 (as per pip show).

The issue itself is the same as #637 and the last comment is the fix, there's another PR addressing this issue #786 but is quiet since May

Also AWS seems to be deprecating PATH addressing style: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access

Thanks to timburnet-systematica and james-masson for their initial work on this.

adsanz · 2022-12-30T13:53:06Z

Note for clarity: Commit made from my work acc PR made from personal acc

github-actions · 2022-12-30T13:53:49Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

adsanz · 2022-12-30T14:07:30Z

Also adding how I tested this change:

> cp plugins/connection/aws_ssm.py /home/adsanz/.ansible/collections/ansible_collections/community/aws/plugins/connection/aws_ssm.py
> AWS_PROFILE=cc-int ansible-playbook -i ../env/int/ansible deploy.yml
PLAY [front] ******************************************************************************************************************************************************************************************************

TASK [Just a test hello there] ************************************************************************************************************************************************************************************
fatal: [i-xxxxxxxxxxxx]: FAILED! => {"changed": false, "module_stderr": "", "module_stdout": "  File \"/home/ssm-user/.ansible/tmp/ansible-tmp-1672409003.9969342-21608-195798520622054/AnsiballZ_command.py\", line 1\r\r\n    <?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\r\n    ^\r\r\nSyntaxError: invalid syntax\r\r", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

PLAY RECAP ********************************************************************************************************************************************************************************************************
i-xxxxxxxxxxxx        : ok=0    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0   

> AWS_PROFILE=cc-int ansible-playbook -i ../env/int/ansible deploy.yml
> vim deploy.yml
> AWS_PROFILE=cc-int ansible-playbook -i ../env/int/ansible deploy.yml
PLAY [front] ******************************************************************************************************************************************************************************************************

TASK [Just a test hello there] ************************************************************************************************************************************************************************************
changed: [i-xxxxxxxxxxxx]

PLAY RECAP ********************************************************************************************************************************************************************************************************
i-xxxxxxxxxxxx        : ok=1    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

The playbook is fairly simple:

- hosts: front
  become: true
  vars:
    ansible_connection: aws_ssm
    ansible_aws_ssm_bucket_name: my-newly-created-bucket
    ansible_aws_ssm_region: eu-west-1
    # edited this part on "vim deploy.yml" and added this variable
    ansible_aws_ssm_s3_addressing_style: virtual
  gather_facts: no
  tasks:
    - name: Just a test hello there
      ansible.builtin.shell:
        cmd: whoami

adsanz · 2023-01-02T10:39:22Z

There's a broken check: https://ansible.softwarefactory-project.io/zuul/build/b47386cb65304135b3cb84f0978a88d5 but test are passing now, let me know if anything else is needed!

tremble · 2023-01-02T16:06:09Z

recheck (this forces a retry on the hopefully no-longer-broken test)

softwarefactory-project-zuul · 2023-01-02T16:24:51Z

Build succeeded.

adsanz · 2023-01-09T14:26:41Z

I'll add this for the record, let me know if should I add this somewhere else, but aliases still don't work, I just tested it and works with the bucket name, but not with the alias. Not sure why

softwarefactory-project-zuul · 2023-01-20T16:15:14Z

Build failed.

softwarefactory-project-zuul · 2023-01-20T16:34:14Z

Build succeeded.

softwarefactory-project-zuul · 2023-01-20T16:55:42Z

Build succeeded (gate pipeline).

patchback · 2023-01-20T16:55:47Z

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/8503d80d2c8477bd1601d419bb73e51bb691498f/pr-1633

Backported as #1669

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…r auto. (#1633) Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. SUMMARY Added the chance of setting up the addressing style for S3 URLs, this fixes #637 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION I came across this issue when I was trying to connect and execute tasks on a fresh AWS set-up (new S3 bucket + EC2), I'm using the latest (5.1.0) release and Ansible 5.10 (as per pip show). The issue itself is the same as #637 and the last comment is the fix, there's another PR addressing this issue #786 but is quiet since May Also AWS seems to be deprecating PATH addressing style: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access Thanks to timburnet-systematica and james-masson for their initial work on this. Reviewed-by: Mark Chappell <None> (cherry picked from commit 8503d80)

…r auto. (#1633) (#1669) [PR #1633/8503d80d backport][stable-5] Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. This is a backport of PR #1633 as merged into main (8503d80). SUMMARY Added the chance of setting up the addressing style for S3 URLs, this fixes #637 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION I came across this issue when I was trying to connect and execute tasks on a fresh AWS set-up (new S3 bucket + EC2), I'm using the latest (5.1.0) release and Ansible 5.10 (as per pip show). The issue itself is the same as #637 and the last comment is the fix, there's another PR addressing this issue #786 but is quiet since May Also AWS seems to be deprecating PATH addressing style: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access Thanks to timburnet-systematica and james-masson for their initial work on this. Reviewed-by: Mark Chappell <None>

…-collections#1633) Document and validate backup_selection conditions suboptions SUMMARY Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes ansible-collections#1613 Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan. ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_selection module_utils.backup ADDITIONAL INFORMATION See ansible-collections#1613 for detailed description of related issue. Reviewed-by: Jill R Reviewed-by: Alina Buzachis

ansibullbot added community_review connection connection plugin feature This issue/PR relates to a feature request needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Dec 30, 2022

This comment was marked as resolved.

Sign in to view

adsanz-atalanta and others added 4 commits January 20, 2023 15:42

Addressyn Style SSM

8596c87

Add example

a443ccf

Add integration tests

a6aeb08

changelog lint

c1b12d5

tremble added the backport-5 PR should be backported to the stable-5 branch label Jan 20, 2023

tremble force-pushed the main branch from c09a47b to c1b12d5 Compare January 20, 2023 14:58

tweak description

5cfa93c

tremble mentioned this pull request Jan 20, 2023

AWS SSM connection: Add ability to specify S3 addressing style #786

Closed

ansibullbot added integration tests/integration tests tests labels Jan 20, 2023

This comment was marked as resolved.

Sign in to view

tremble approved these changes Jan 20, 2023

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 20, 2023

This comment was marked as resolved.

Sign in to view

Tweak tests so s3 buckets have unique names

50a2d7d

tremble force-pushed the main branch from cb6eac9 to 50a2d7d Compare January 20, 2023 16:15

softwarefactory-project-zuul bot merged commit 8503d80 into ansible-collections:main Jan 20, 2023

patchback bot mentioned this pull request Jan 20, 2023

[PR #1633/8503d80d backport][stable-5] Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. #1669

Merged

This was referenced Jan 20, 2023

Fix/ssm bucket auth #854

Closed

SSM connection - set S3 addressing style #722

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. #1633

Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. #1633

adsanz commented Dec 30, 2022 •

edited by tremble

Loading

adsanz commented Dec 30, 2022

github-actions bot commented Dec 30, 2022 •

edited

Loading

adsanz commented Dec 30, 2022 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

adsanz commented Jan 2, 2023

tremble commented Jan 2, 2023 •

edited

Loading

softwarefactory-project-zuul bot commented Jan 2, 2023

adsanz commented Jan 9, 2023

This comment was marked as resolved.

This comment was marked as resolved.

softwarefactory-project-zuul bot commented Jan 20, 2023

softwarefactory-project-zuul bot commented Jan 20, 2023

softwarefactory-project-zuul bot commented Jan 20, 2023

patchback bot commented Jan 20, 2023 •

edited

Loading

Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. #1633

Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. #1633

Conversation

adsanz commented Dec 30, 2022 • edited by tremble Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

adsanz commented Dec 30, 2022

github-actions bot commented Dec 30, 2022 • edited Loading

Docs Build 📝

adsanz commented Dec 30, 2022 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

adsanz commented Jan 2, 2023

tremble commented Jan 2, 2023 • edited Loading

softwarefactory-project-zuul bot commented Jan 2, 2023

adsanz commented Jan 9, 2023

This comment was marked as resolved.

This comment was marked as resolved.

softwarefactory-project-zuul bot commented Jan 20, 2023

softwarefactory-project-zuul bot commented Jan 20, 2023

softwarefactory-project-zuul bot commented Jan 20, 2023

patchback bot commented Jan 20, 2023 • edited Loading

Backport to stable-5: 💚 backport PR created

adsanz commented Dec 30, 2022 •

edited by tremble

Loading

github-actions bot commented Dec 30, 2022 •

edited

Loading

adsanz commented Dec 30, 2022 •

edited

Loading

tremble commented Jan 2, 2023 •

edited

Loading

patchback bot commented Jan 20, 2023 •

edited

Loading