aws_ssm - Refactor boto3 client initialization #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
connection
tremble
force-pushed
the
cleanup/aws_ssm/client
branch
from
f13773a
to
93098f1
Compare
tremble
force-pushed
the
cleanup/aws_ssm/client
branch
from
93098f1
to
dbbe41b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
markuman
added
backport-5
markuman
approved these changes
Jan 19, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
aws_ssm - Refactor _file_transport_command Depends-On: ansible/ansible-zuul-jobs#1748 Depends-On: #1663 SUMMARY Yet more cleanup of aws_ssm ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
patchback bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
aws_ssm - Refactor _file_transport_command Depends-On: ansible/ansible-zuul-jobs#1748 Depends-On: #1663 SUMMARY Yet more cleanup of aws_ssm ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 7b68f11)
patchback bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
aws_ssm - Refactor _file_transport_command Depends-On: ansible/ansible-zuul-jobs#1748 Depends-On: #1663 SUMMARY Yet more cleanup of aws_ssm ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 7b68f11)
tremble
added
backport-5
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1668 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
aws_ssm - Refactor boto3 client initialization Depends-On: ansible/ansible-zuul-jobs#1748 SUMMARY Move the boto3 client initialization into a consistent point (rather than initializing them on the fly) ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION In preparation for further refactoring and using ansible-collections/amazon.aws#1340 Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 5759afa)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
[PR #1663/5759afa1 backport][stable-5] aws_ssm - Refactor boto3 client initialization This is a backport of PR #1663 as merged into main (5759afa). Depends-On: ansible/ansible-zuul-jobs#1748 SUMMARY Move the boto3 client initialization into a consistent point (rather than initializing them on the fly) ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION In preparation for further refactoring and using ansible-collections/amazon.aws#1340 Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ing GlobalClusterIdentifier (ansible-collections#1663) Allow user to associate rds cluster with a global rds cluster SUMMARY Allow user to associate rds cluster with a global rds cluster ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Mandar Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1748
SUMMARY
Move the boto3 client initialization into a consistent point (rather than initializing them on the fly)
ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
In preparation for further refactoring and using ansible-collections/amazon.aws#1340