ecs_service -- with force_new_deployment user can specify taskdef or not #1680
Conversation
karcadia
changed the title
ansibullbot
added
community_review
feature
There was a problem hiding this comment.
@karcadia Thank you for taking time to open this pull request. Would you be willing to add some integration tests for this functionality? Thanks.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
force-pushed
the
force_redeploy_taskdef_optional
branch
from
f8f0e5f
to
0d43b28
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 56s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
markuman
added
mergeit
|
recheck |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 48s |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1732 🤖 @patchback |
…not (#1680) ecs_service -- with force_new_deployment user can specify taskdef or not SUMMARY Fixes #1106 Support force_new_deployment without having to specify a task definition. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Previously task_definition was required when state was present; regardless of whether force_new_deployment was set or not. Previous error was along the lines of "state is present but all of the following are missing: task_definition". New behavior enforces either task_definition or force_new_deployment is set. If both are provided, the user's task_definition will be sent through to boto. If only task_definition is defined, original behavior resumes. If only force_new_deployment is set, pull the taskDefinition from existing and pass it through to boto. Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 6f84424)
…not (#1680) (#1732) [PR #1680/6f844249 backport][stable-5] ecs_service -- with force_new_deployment user can specify taskdef or not This is a backport of PR #1680 as merged into main (6f84424). SUMMARY Fixes #1106 Support force_new_deployment without having to specify a task definition. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Previously task_definition was required when state was present; regardless of whether force_new_deployment was set or not. Previous error was along the lines of "state is present but all of the following are missing: task_definition". New behavior enforces either task_definition or force_new_deployment is set. If both are provided, the user's task_definition will be sent through to boto. If only task_definition is defined, original behavior resumes. If only force_new_deployment is set, pull the taskDefinition from existing and pass it through to boto. Reviewed-by: Mark Chappell
SUMMARY
Fixes #1106
Support force_new_deployment without having to specify a task definition.
ISSUE TYPE
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
Previously task_definition was required when state was present; regardless of whether force_new_deployment was set or not.
Previous error was along the lines of "state is present but all of the following are missing: task_definition".
New behavior enforces either task_definition or force_new_deployment is set.
If both are provided, the user's task_definition will be sent through to boto.
If only task_definition is defined, original behavior resumes.
If only force_new_deployment is set, pull the taskDefinition from existing and pass it through to boto.