Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #827/c7c68009 backport][stable-5] Add secret manager replication support #1685

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 31, 2023

This is a backport of PR #827 as merged into main (c7c6800).

Signed-off-by: Eric Millbrandt [email protected]

SUMMARY

Add support for regional secret replication. The component now supports:

  • Creating a secret with a regional replica
  • Adding a region replica to a secret
  • Removing a region replica from a secret
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_secret

ADDITIONAL INFORMATION

https://aws.amazon.com/about-aws/whats-new/2021/03/aws-secrets-manager-provides-support-to-replicate-secrets-in-aws-secrets-manager-to-multiple-aws-regions/
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/secretsmanager.html

Add secret manager replication support

Signed-off-by: Eric Millbrandt [email protected]
SUMMARY
Add support for regional secret replication.  The component now supports:

Creating a secret with a regional replica
Adding a region replica to a secret
Removing a region replica from a secret

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_secret
ADDITIONAL INFORMATION
https://aws.amazon.com/about-aws/whats-new/2021/03/aws-secrets-manager-provides-support-to-replicate-secrets-in-aws-secrets-manager-to-multiple-aws-regions/
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/secretsmanager.html

Reviewed-by: Eric Millbrandt <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>
(cherry picked from commit c7c6800)
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 31, 2023
@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Jan 31, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 6m 32s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 45s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 01s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 40s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 44s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 45s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 04s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 37s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 12s
✔️ ansible-test-changelog SUCCESS in 2m 18s
✔️ ansible-test-splitter SUCCESS in 2m 35s
✔️ integration-community.aws-1 SUCCESS in 7m 02s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5c39343 into stable-5 Jan 31, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/c7c68009080e4e28828ed435db02cdad83712ac6/pr-827 branch January 31, 2023 15:26
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes ansible-collections#1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants