-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #827/c7c68009 backport][stable-5] Add secret manager replication support #1685
Merged
softwarefactory-project-zuul
merged 1 commit into
stable-5
from
patchback/backports/stable-5/c7c68009080e4e28828ed435db02cdad83712ac6/pr-827
Jan 31, 2023
Merged
[PR #827/c7c68009 backport][stable-5] Add secret manager replication support #1685
softwarefactory-project-zuul
merged 1 commit into
stable-5
from
patchback/backports/stable-5/c7c68009080e4e28828ed435db02cdad83712ac6/pr-827
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add secret manager replication support Signed-off-by: Eric Millbrandt [email protected] SUMMARY Add support for regional secret replication. The component now supports: Creating a secret with a regional replica Adding a region replica to a secret Removing a region replica from a secret ISSUE TYPE Feature Pull Request COMPONENT NAME aws_secret ADDITIONAL INFORMATION https://aws.amazon.com/about-aws/whats-new/2021/03/aws-secrets-manager-provides-support-to-replicate-secrets-in-aws-secrets-manager-to-multiple-aws-regions/ https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/secretsmanager.html Reviewed-by: Eric Millbrandt <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> (cherry picked from commit c7c6800)
tremble
approved these changes
Jan 31, 2023
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
tests
tests
labels
Jan 31, 2023
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/c7c68009080e4e28828ed435db02cdad83712ac6/pr-827
branch
January 31, 2023 15:26
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ssm_parameter: update examples to use FQCN SUMMARY This PR update examples to use FQCN. Fixes ansible-collections#1581 Should get reflected in module documentation on next doc generation. ISSUE TYPE Docs Pull Request COMPONENT NAME amazon.aws.ssm_parameter ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #827 as merged into main (c7c6800).
Signed-off-by: Eric Millbrandt [email protected]
SUMMARY
Add support for regional secret replication. The component now supports:
ISSUE TYPE
COMPONENT NAME
aws_secret
ADDITIONAL INFORMATION
https://aws.amazon.com/about-aws/whats-new/2021/03/aws-secrets-manager-provides-support-to-replicate-secrets-in-aws-secrets-manager-to-multiple-aws-regions/
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/secretsmanager.html