Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1606/3391b27d backport][stable-5] s3_lifecycle - ability to set the number of newest noncurrent versions to retain #1687

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 1, 2023

This is a backport of PR #1606 as merged into main (3391b27).

SUMMARY

Adds the ability to set "Number of newer versions to retain"

image

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

s3_lifecycle

ADDITIONAL INFORMATION

See: https://docs.aws.amazon.com/AmazonS3/latest/API/API_NoncurrentVersionExpiration.html

Previously only the NoncurrentDays parameter was supported, this PR adds support for NewerNoncurrentVersions

…s to retain (#1606)

s3_lifecycle - ability to set the number of newest noncurrent versions to retain

SUMMARY
Adds the ability to set "Number of newer versions to retain"

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_lifecycle
ADDITIONAL INFORMATION
See: https://docs.aws.amazon.com/AmazonS3/latest/API/API_NoncurrentVersionExpiration.html
Previously only the NoncurrentDays parameter was supported, this PR adds support for NewerNoncurrentVersions

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 3391b27)
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 5m 46s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 59s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 22s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 53s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 45s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 01s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 52s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 20s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 50s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 10s
✔️ ansible-test-changelog SUCCESS in 2m 13s
✔️ ansible-test-splitter SUCCESS in 2m 51s
✔️ integration-community.aws-1 SUCCESS in 25m 36s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 1, 2023
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Feb 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 5m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 32s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 24s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 12s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 59s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 42s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 41s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 01s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 55s
✔️ ansible-test-changelog SUCCESS in 2m 23s
✔️ ansible-test-splitter SUCCESS in 2m 31s
✔️ integration-community.aws-1 SUCCESS in 26m 12s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 68c0ac4 into stable-5 Feb 1, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/3391b27d0c856d7b044de2a49da730cc6e5481f9/pr-1606 branch February 1, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants