Add http3 support in cloudfront_distribution module #1753

boutetnico · 2023-03-20T13:08:22Z

SUMMARY

Add http3 support to cloudfront_distribution module.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

cloudfront_distribution.py

ADDITIONAL INFORMATION

Tests failure seem to be unrelated to this PR.

github-actions · 2023-03-20T13:26:07Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2023-03-20T14:04:00Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e12f5f53e7fb48cb924efa6d7cfd6121

markuman · 2023-04-03T07:49:04Z

hmm the integration test was successfull. it is failing in the very last task. Wait for cloudfront to be deleted.... with the error message

botocore.errorfactory.NoSuchDistribution: An error occurred (NoSuchDistribution) when calling the GetDistribution operation: The specified distribution does not exist.

that is expected and correct

markuman · 2023-04-03T07:49:12Z

recheck

changelogs/fragments/1753-cloudfront-add-http3.yml

plugins/modules/cloudfront_distribution.py

ansibullbot · 2023-04-03T07:57:58Z

cc @jillr @s-hertel @tremble @wilvk
click here for bot help

softwarefactory-project-zuul · 2023-04-03T08:53:56Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/61c68422f2bd49c2b0bf70d9d973d71e

✔️ ansible-galaxy-importer SUCCESS in 3m 42s
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 38s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 14m 14s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 02s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 38s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 38s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 22s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 28s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 54s
✔️ ansible-test-changelog SUCCESS in 4m 27s
✔️ ansible-test-splitter SUCCESS in 4m 54s
❌ integration-community.aws-1 FAILURE in 38m 05s
Skipped 21 jobs

markuman · 2023-04-03T14:35:29Z

@boutetnico can you also applay the darker formations please? https://github.com/ansible-collections/community.aws/actions/runs/4594279962/jobs/8113117342?pr=1753

softwarefactory-project-zuul · 2023-04-03T16:33:28Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/96c398c28fd0493cbdbaba8539ebb989

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 12m 50s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 21s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 07s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 44s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 51s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 00s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 40s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 35s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 58s
✔️ ansible-test-changelog SUCCESS in 4m 19s
✔️ ansible-test-splitter SUCCESS in 4m 40s
❌ integration-community.aws-1 FAILURE in 43m 38s
Skipped 21 jobs

markuman · 2023-04-03T16:52:17Z

hmmm

botocore.errorfactory.TooManyCloudFrontOriginAccessIdentities: An error occurred (TooManyCloudFrontOriginAccessIdentities) when calling the CreateCloudFrontOriginAccessIdentity operation: Processing your request will cause you to exceed the maximum number of CloudFront origin access identities allowed.

lets do a retry tomorrow, maybe the aws-terminator cleans it up.

mattclay · 2023-04-03T17:06:16Z

@markuman I don't see any code in aws-terminator to clean up the origin access identities. The docs for querying them in boto3 are here: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront/client/list_cloud_front_origin_access_identities.html

The default limit is 100 according to: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/cloudfront-limits.html

mattclay · 2023-04-03T17:07:25Z

/cc @gravesm

gravesm · 2023-04-03T19:08:54Z

recheck

softwarefactory-project-zuul · 2023-04-03T20:00:56Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7225c85ace69410f86c5455fbaf2dc9a

markuman · 2023-04-04T18:13:57Z

recheck

softwarefactory-project-zuul · 2023-04-04T18:52:01Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/418e5cf409274723b9a85dc0f7be8a00

softwarefactory-project-zuul · 2023-04-12T07:52:11Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/c4be4cfd7fe943b5a002ceb2f80ee56a

❌ ansible-galaxy-importer FAILURE in 3m 59s
✔️ build-ansible-collection SUCCESS in 13m 19s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 12s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 04s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 45s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 03s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 32s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 17s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 51s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 54s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 10s
✔️ ansible-test-changelog SUCCESS in 4m 23s
✔️ ansible-test-splitter SUCCESS in 4m 59s
✔️ integration-community.aws-1 SUCCESS in 23m 13s
Skipped 21 jobs

markuman · 2023-04-13T19:36:59Z

recheck

softwarefactory-project-zuul · 2023-04-13T20:17:23Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/84053757e79848638a2d0cf5e66db085

❌ ansible-galaxy-importer FAILURE in 3m 53s
✔️ build-ansible-collection SUCCESS in 13m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 09s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 31s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 15s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 10s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 23s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 20s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 52s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 51s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 02s
✔️ ansible-test-changelog SUCCESS in 4m 33s
✔️ ansible-test-splitter SUCCESS in 5m 07s
✔️ integration-community.aws-1 SUCCESS in 25m 07s
Skipped 21 jobs

markuman · 2023-04-17T17:15:36Z

recheck

softwarefactory-project-zuul · 2023-04-17T17:54:01Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/dee8638c000449cf94fb27213bc9e36c

softwarefactory-project-zuul · 2023-04-17T18:32:46Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/fda648bb4f864576bed8b32f31947b53

patchback · 2023-04-17T18:32:51Z

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply dc6b458 on top of patchback/backports/stable-5/dc6b4585c91898a59394b21400654ab89a2e5bd8/pr-1753

Backporting merged PR #1753 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/community.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-5/dc6b4585c91898a59394b21400654ab89a2e5bd8/pr-1753 upstream/stable-5

Now, cherry-pick PR Add http3 support in cloudfront_distribution module #1753 contents into that branch:
```
$ git cherry-pick -x dc6b4585c91898a59394b21400654ab89a2e5bd8
```
If it'll yell at you with something like fatal: Commit dc6b4585c91898a59394b21400654ab89a2e5bd8 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x dc6b4585c91898a59394b21400654ab89a2e5bd8
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Add http3 support in cloudfront_distribution module #1753 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-5/dc6b4585c91898a59394b21400654ab89a2e5bd8/pr-1753

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

markuman reviewed Apr 3, 2023

View reviewed changes

changelogs/fragments/1753-cloudfront-add-http3.yml Outdated Show resolved Hide resolved

markuman reviewed Apr 3, 2023

View reviewed changes

plugins/modules/cloudfront_distribution.py Outdated Show resolved Hide resolved

markuman added the backport-5 PR should be backported to the stable-5 branch label Apr 3, 2023

markuman added this to the 5.5.0 milestone Apr 3, 2023

ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests labels Apr 3, 2023

boutetnico force-pushed the cloudfront-http3 branch from 70dd8c2 to a9a9a33 Compare April 3, 2023 15:29

boutetnico and others added 6 commits April 3, 2023 17:30

Add http3 support in cloudfront_distribution module

d618ed4

Add changelog

c279108

Update changelogs/fragments/1753-cloudfront-add-http3.yml

a359126

Fix msitake

605d71a

Fix typo

97d993f

Apply darker on cloudfront_distribution.py

b1ace9e

boutetnico force-pushed the cloudfront-http3 branch from a9a9a33 to b1ace9e Compare April 3, 2023 15:30

markuman approved these changes Apr 4, 2023

View reviewed changes

markuman requested review from tremble and alinabuzachis April 4, 2023 05:40

markuman added the mergeit Merge the PR (SoftwareFactory) label Apr 12, 2023

abikouo mentioned this pull request Apr 12, 2023

CI - add changelog validation job [Github action] ansible-collections/amazon.aws#1458

Closed

markuman removed the mergeit Merge the PR (SoftwareFactory) label Apr 13, 2023

markuman added the mergeit Merge the PR (SoftwareFactory) label Apr 17, 2023

softwarefactory-project-zuul bot merged commit dc6b458 into ansible-collections:main Apr 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add http3 support in cloudfront_distribution module #1753

Add http3 support in cloudfront_distribution module #1753

boutetnico commented Mar 20, 2023 •

edited

Loading

github-actions bot commented Mar 20, 2023 •

edited

Loading

softwarefactory-project-zuul bot commented Mar 20, 2023

markuman commented Apr 3, 2023

markuman commented Apr 3, 2023

ansibullbot commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

markuman commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

markuman commented Apr 3, 2023

mattclay commented Apr 3, 2023

mattclay commented Apr 3, 2023

gravesm commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

markuman commented Apr 4, 2023

softwarefactory-project-zuul bot commented Apr 4, 2023

softwarefactory-project-zuul bot commented Apr 12, 2023

markuman commented Apr 13, 2023

softwarefactory-project-zuul bot commented Apr 13, 2023

markuman commented Apr 17, 2023

softwarefactory-project-zuul bot commented Apr 17, 2023

softwarefactory-project-zuul bot commented Apr 17, 2023

patchback bot commented Apr 17, 2023 •

edited

Loading

Add http3 support in cloudfront_distribution module #1753

Add http3 support in cloudfront_distribution module #1753

Conversation

boutetnico commented Mar 20, 2023 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions bot commented Mar 20, 2023 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Mar 20, 2023

markuman commented Apr 3, 2023

markuman commented Apr 3, 2023

ansibullbot commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

markuman commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

markuman commented Apr 3, 2023

mattclay commented Apr 3, 2023

mattclay commented Apr 3, 2023

gravesm commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

markuman commented Apr 4, 2023

softwarefactory-project-zuul bot commented Apr 4, 2023

softwarefactory-project-zuul bot commented Apr 12, 2023

markuman commented Apr 13, 2023

softwarefactory-project-zuul bot commented Apr 13, 2023

markuman commented Apr 17, 2023

softwarefactory-project-zuul bot commented Apr 17, 2023

softwarefactory-project-zuul bot commented Apr 17, 2023

patchback bot commented Apr 17, 2023 • edited Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1753 into main

boutetnico commented Mar 20, 2023 •

edited

Loading

github-actions bot commented Mar 20, 2023 •

edited

Loading

patchback bot commented Apr 17, 2023 •

edited

Loading