Commits on May 5, 2023

1. cloudformation_stack_set - Add a waiter to ensure that running operat… …

   …ions against existing stacksets complete (#1790)
   
   cloudformation_stack_set - Add a waiter to ensure that running operations against existing stacksets complete
   
   SUMMARY
   Add a waiter to ensure that running operations against existing stacksets complete. Current code would fail in cases where new instances need to be added since the previous update_stack_set(module, stack_params, cfn) would still be running.
   Fixes #1608
   ISSUE TYPE
   
   Bugfix Pull Request
   
   COMPONENT NAME
   cloudformation_stack_set
   ADDITIONAL INFORMATION
   I initially thought that the module was not idempotent since new instances wouldn't be added to my existing stack sets. Upon closer examination, the issue had to do with the fact that we had prior calls being made before adding new instances to existing stack sets:
   raise error_class(parsed_response, operation_name)\nbotocore.errorfactory.OperationInProgressException:
       An error occurred (OperationInProgressException) when calling the UpdateStackInstances operation:
       Another Operation on StackSet arn:aws:cloudformation:us-east-1:XXXXXX:stackset/aws-config-stackset:2bcb419a-f263-48ca-9fe0-cdef11fb59de is in progress
   The error got triggered because of a missing waiter after this operation:
   changed |= update_stack_set(module, stack_params, cfn)
   This change add a waiter function after the update operation, which, in turn, ensure that the subsequent call to add stack instances to the stack set properly run.
   
   Reviewed-by: Mark Chappell
   (cherry picked from commit 2c91768)

   

   rmahroua authored and patchback[bot] committed May 5, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 42348b0
   • Browse repository at this point

   Copy the full SHA

   42348b0 View commit details

   Browse the repository at this point in the history