Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api_gateway - add parameter name #1845

Merged

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 20, 2023

SUMMARY

api_gateway - Add parameter name to defined the name of the API gateway to create/update, default to ansible-temp-api for backward compatibility

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

api_gateway

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e1401182b05146bb9fcbcd90b8c506a4

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 13m 08s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-community.aws-1 SUCCESS in 10m 29s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a532c9cd0bc34742b61bd02379b1ba11

ansible-galaxy-importer FAILURE in 4m 37s
✔️ build-ansible-collection SUCCESS in 13m 08s
✔️ ansible-test-splitter SUCCESS in 5m 19s
integration-community.aws-1 FAILURE in 9m 59s
Skipped 21 jobs

@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/af9bfa75d3684f5b8a1dc5e3d3c4f193

✔️ ansible-galaxy-importer SUCCESS in 4m 45s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 55s
✔️ ansible-test-splitter SUCCESS in 5m 02s
✔️ integration-community.aws-1 SUCCESS in 10m 11s
Skipped 21 jobs

@alinabuzachis alinabuzachis added the backport-6 PR should be backported to the stable-6 branch label Jun 30, 2023
@alinabuzachis alinabuzachis added this to the 6.1.0 milestone Jun 30, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ff8da75c0e844f3d985a5cc6260594bc

ansible-galaxy-importer FAILURE in 4m 07s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 05s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-community.aws-1 SUCCESS in 9m 59s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/73c5e1dfddd046649a8c04d0b80e1cd0

✔️ ansible-galaxy-importer SUCCESS in 4m 39s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 43s
✔️ ansible-test-splitter SUCCESS in 5m 30s
✔️ integration-community.aws-1 SUCCESS in 8m 28s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5fdbc054f70a42269b01d49e61028e6b

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection (non-voting)
build-ansible-collection RETRY_LIMIT in 7m 02s
ansible-test-splitter RETRY_LIMIT in 6m 38s
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ed0d30d9275c4aa3a2ad6a6a12dfba1f

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection (non-voting)
build-ansible-collection RETRY_LIMIT in 6m 48s
ansible-test-splitter RETRY_LIMIT in 6m 25s
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

@abikouo abikouo removed this from the 6.1.0 milestone Jul 10, 2023
@abikouo
Copy link
Contributor Author

abikouo commented Jul 10, 2023

@tremble @alinabuzachis purge_tags support has been added, the PR is ready for review

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/332acdfb1f0645b6b41571074ae71b66

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection (non-voting)
build-ansible-collection RETRY_LIMIT in 6m 52s
ansible-test-splitter RETRY_LIMIT in 7m 05s
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

meta/runtime.yml Show resolved Hide resolved
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, minor niggles but nothing else is jumping out at me.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/36b85d917fc9419bbd3a26d039f2c8e5

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection (non-voting)
build-ansible-collection RETRY_LIMIT in 10m 59s
ansible-test-splitter RETRY_LIMIT in 10m 59s
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

@abikouo abikouo requested a review from tremble July 12, 2023 14:10
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6b0624b91e884790b2e57abf70c8ace2

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection (non-voting)
build-ansible-collection RETRY_LIMIT in 11m 33s
ansible-test-splitter RETRY_LIMIT in 10m 42s
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

@jillr
Copy link
Collaborator

jillr commented Jul 12, 2023

recheck

@ansibullbot
Copy link

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/cf6bc2ef509c4b50b6375baf54bd6d9d

✔️ ansible-galaxy-importer SUCCESS in 5m 39s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 13s
✔️ ansible-test-splitter SUCCESS in 4m 54s
✔️ integration-community.aws-1 SUCCESS in 13m 12s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5eea88fac70448c5a9977e1338447e3b

✔️ ansible-galaxy-importer SUCCESS in 4m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 31s
✔️ ansible-test-splitter SUCCESS in 5m 31s
✔️ integration-community.aws-1 SUCCESS in 12m 10s
Skipped 21 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Aug 1, 2023
@abikouo
Copy link
Contributor Author

abikouo commented Aug 1, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c38d481f5dca494ba52c486a7127aa42

✔️ ansible-galaxy-importer SUCCESS in 3m 57s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 12s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-community.aws-1 SUCCESS in 11m 16s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6d7daaf into ansible-collections:main Aug 1, 2023
56 of 58 checks passed
@patchback
Copy link

patchback bot commented Aug 1, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/6d7daafc99fda99b0480bba077177fda41cf0b79/pr-1845

Backported as #1901

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 1, 2023
api_gateway - add parameter name

SUMMARY
api_gateway - Add parameter name to defined the name of the API gateway to create/update, default to ansible-temp-api for backward compatibility
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

api_gateway
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: Mark Chappell
(cherry picked from commit 6d7daaf)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 1, 2023
[PR #1845/6d7daafc backport][stable-6] api_gateway - add parameter name

This is a backport of PR #1845 as merged into main (6d7daaf).
SUMMARY
api_gateway - Add parameter name to defined the name of the API gateway to create/update, default to ansible-temp-api for backward compatibility
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

api_gateway
ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Alina Buzachis
@gravesm
Copy link
Member

gravesm commented Aug 3, 2023

@abikouo I realize this has already been merged, but I just noticed that @tremble's comment was resolved without explanation. Is there a reason why apigateway and apigateway_deployment weren't removed in the final PR?

@abikouo
Copy link
Contributor Author

abikouo commented Aug 4, 2023

@abikouo I realize this has already been merged, but I just noticed that @tremble's comment was resolved without explanation. Is there a reason why apigateway and apigateway_deployment weren't removed in the final PR?

That's strange, I may have forgotten to push the local change on this branch because when I resolved a comment I performed the commit. However I have created #1905 to resolve this issue

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 4, 2023
)

Remove apigateway and apigateway_deployment from meta/runtime.yml

SUMMARY

#1845 has accidentally added apigateway and apigateway_deployment on meta/runtime.yml
This PR aims to remove that

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

meta/runtime.yml

Reviewed-by: Alina Buzachis
patchback bot pushed a commit that referenced this pull request Aug 4, 2023
)

Remove apigateway and apigateway_deployment from meta/runtime.yml

SUMMARY

#1845 has accidentally added apigateway and apigateway_deployment on meta/runtime.yml
This PR aims to remove that

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

meta/runtime.yml

Reviewed-by: Alina Buzachis
(cherry picked from commit 09c3498)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 4, 2023
) (#1906)

[PR #1905/09c34986 backport][stable-6] Remove apigateway and apigateway_deployment from meta/runtime.yml

This is a backport of PR #1905 as merged into main (09c3498).
SUMMARY

#1845 has accidentally added apigateway and apigateway_deployment on meta/runtime.yml
This PR aims to remove that

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

meta/runtime.yml

Reviewed-by: Alina Buzachis
@abikouo abikouo deleted the api_gateway_v1 branch October 15, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants