-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api_gateway - add parameter name #1845
api_gateway - add parameter name #1845
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 13s |
fa4d32e
to
9799fcb
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 37s |
recheck |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 45s (non-voting) |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 07s (non-voting) |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 39s (non-voting) |
Build failed.
|
Build failed.
|
@tremble @alinabuzachis |
Build failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, minor niggles but nothing else is jumping out at me.
changelogs/fragments/20230620-api_gateway-add-optional-name.yml
Outdated
Show resolved
Hide resolved
Build failed.
|
Build failed.
|
recheck |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 39s (non-voting) |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 09s (non-voting) |
regate |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 57s (non-voting) |
6d7daaf
into
ansible-collections:main
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1901 🤖 @patchback |
api_gateway - add parameter name SUMMARY api_gateway - Add parameter name to defined the name of the API gateway to create/update, default to ansible-temp-api for backward compatibility ISSUE TYPE Feature Pull Request COMPONENT NAME api_gateway ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Mark Chappell (cherry picked from commit 6d7daaf)
[PR #1845/6d7daafc backport][stable-6] api_gateway - add parameter name This is a backport of PR #1845 as merged into main (6d7daaf). SUMMARY api_gateway - Add parameter name to defined the name of the API gateway to create/update, default to ansible-temp-api for backward compatibility ISSUE TYPE Feature Pull Request COMPONENT NAME api_gateway ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis
That's strange, I may have forgotten to push the local change on this branch because when I resolved a comment I performed the commit. However I have created #1905 to resolve this issue |
) Remove apigateway and apigateway_deployment from meta/runtime.yml SUMMARY #1845 has accidentally added apigateway and apigateway_deployment on meta/runtime.yml This PR aims to remove that ISSUE TYPE Bugfix Pull Request COMPONENT NAME meta/runtime.yml Reviewed-by: Alina Buzachis
) Remove apigateway and apigateway_deployment from meta/runtime.yml SUMMARY #1845 has accidentally added apigateway and apigateway_deployment on meta/runtime.yml This PR aims to remove that ISSUE TYPE Bugfix Pull Request COMPONENT NAME meta/runtime.yml Reviewed-by: Alina Buzachis (cherry picked from commit 09c3498)
) (#1906) [PR #1905/09c34986 backport][stable-6] Remove apigateway and apigateway_deployment from meta/runtime.yml This is a backport of PR #1905 as merged into main (09c3498). SUMMARY #1845 has accidentally added apigateway and apigateway_deployment on meta/runtime.yml This PR aims to remove that ISSUE TYPE Bugfix Pull Request COMPONENT NAME meta/runtime.yml Reviewed-by: Alina Buzachis
SUMMARY
api_gateway
- Add parametername
to defined the name of the API gateway to create/update, default toansible-temp-api
for backward compatibilityISSUE TYPE
COMPONENT NAME
api_gateway
ADDITIONAL INFORMATION