Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various ARN handling fixes #1848

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 21, 2023

Depends-On: ansible-collections/amazon.aws#1619

SUMMARY

fixes: #1846

Various modules had hard-coded ARN handling which assumed the use of the main partition. This causes problems for folks using Gov Cloud (and aws-cn)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/batch_compute_environment.py
plugins/modules/ec2_launch_template.py
plugins/modules/elasticache_info.py
plugins/modules/iam_group.py
plugins/modules/iam_role.py
plugins/modules/msk_config.py
plugins/modules/redshift.py
plugins/modules/sns_topic.py

ADDITIONAL INFORMATION

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fd07fc0050494354a9e4ae90b4bcb356

✔️ ansible-galaxy-importer SUCCESS in 4m 44s
✔️ build-ansible-collection SUCCESS in 12m 45s
ansible-test-sanity-docker-devel FAILURE in 12m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 10s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 01s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 33s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 14m 19s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 57s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 23s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 39s
ansible-test-units-amazon-aws-python310 FAILURE in 6m 02s (non-voting)
✔️ ansible-test-changelog SUCCESS in 4m 43s
✔️ ansible-test-splitter SUCCESS in 5m 19s
✔️ integration-community.aws-1 SUCCESS in 25m 21s
✔️ integration-community.aws-2 SUCCESS in 6m 35s
✔️ integration-community.aws-3 SUCCESS in 9m 25s
✔️ integration-community.aws-4 SUCCESS in 8m 58s
✔️ integration-community.aws-5 SUCCESS in 9m 20s
✔️ integration-community.aws-6 SUCCESS in 5m 44s
✔️ integration-community.aws-7 SUCCESS in 5m 42s
Skipped 15 jobs

@tremble tremble marked this pull request as ready for review June 21, 2023 14:04
@tremble tremble force-pushed the issue/1846 branch 2 times, most recently from 182c2b5 to 841403b Compare June 22, 2023 07:08
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/74438d42ec98451cbeb2e69d404fd65d

ansible-galaxy-importer FAILURE in 4m 03s
✔️ build-ansible-collection SUCCESS in 13m 19s
ansible-test-sanity-docker-devel FAILURE in 10m 40s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 27s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 14s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 55s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 37s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 31s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 55s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 05s
ansible-test-units-amazon-aws-python310 FAILURE in 7m 01s (non-voting)
✔️ ansible-test-changelog SUCCESS in 4m 49s
✔️ ansible-test-splitter SUCCESS in 5m 05s
✔️ integration-community.aws-1 SUCCESS in 23m 26s
✔️ integration-community.aws-2 SUCCESS in 6m 32s
✔️ integration-community.aws-3 SUCCESS in 6m 56s
✔️ integration-community.aws-4 SUCCESS in 6m 55s
✔️ integration-community.aws-5 SUCCESS in 7m 20s
✔️ integration-community.aws-6 SUCCESS in 5m 44s
✔️ integration-community.aws-7 SUCCESS in 5m 49s
Skipped 15 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fd2a8e6816bb4cac910251b6e65e15dd

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 12m 31s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-community.aws-1 SUCCESS in 21m 31s
✔️ integration-community.aws-2 SUCCESS in 6m 03s
✔️ integration-community.aws-3 SUCCESS in 7m 17s
✔️ integration-community.aws-4 SUCCESS in 6m 32s
✔️ integration-community.aws-5 SUCCESS in 5m 51s
✔️ integration-community.aws-6 SUCCESS in 5m 29s
✔️ integration-community.aws-7 SUCCESS in 6m 07s
Skipped 15 jobs

fixes: ansible-collections#1846

Various modules had hard-coded ARN handling which assumed the use of the main  partition.  This causes problems for folks using Gov Cloud (and aws-cn)
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/7258e201995a411d934e4e81b2ce9fb4

✔️ ansible-galaxy-importer SUCCESS in 4m 37s (non-voting)
✔️ build-ansible-collection SUCCESS in 27m 35s
✔️ ansible-test-splitter SUCCESS in 5m 36s
✔️ integration-community.aws-1 SUCCESS in 28m 05s
✔️ integration-community.aws-2 SUCCESS in 5m 39s
✔️ integration-community.aws-3 SUCCESS in 8m 35s
✔️ integration-community.aws-4 SUCCESS in 8m 05s
✔️ integration-community.aws-5 SUCCESS in 8m 45s
✔️ integration-community.aws-6 SUCCESS in 8m 37s
✔️ integration-community.aws-7 SUCCESS in 6m 28s
Skipped 15 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 25a636c into ansible-collections:main Jun 26, 2023
41 of 72 checks passed
@tremble tremble added the backport-6 PR should be backported to the stable-6 branch label Jun 27, 2023
@patchback
Copy link

patchback bot commented Jun 27, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/25a636cefa0defcd1022c94aa2a38bdcf4763afd/pr-1848

Backported as #1858

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 27, 2023
Various ARN handling fixes

Depends-On: ansible-collections/amazon.aws#1619
SUMMARY
fixes: #1846
Various modules had hard-coded ARN handling which assumed the use of the main  partition.  This causes problems for folks using Gov Cloud (and aws-cn)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/batch_compute_environment.py
plugins/modules/ec2_launch_template.py
plugins/modules/elasticache_info.py
plugins/modules/iam_group.py
plugins/modules/iam_role.py
plugins/modules/msk_config.py
plugins/modules/redshift.py
plugins/modules/sns_topic.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 25a636c)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 27, 2023
[PR #1848/25a636ce backport][stable-6] Various ARN handling fixes

This is a backport of PR #1848 as merged into main (25a636c).
Depends-On: ansible-collections/amazon.aws#1619
SUMMARY
fixes: #1846
Various modules had hard-coded ARN handling which assumed the use of the main  partition.  This causes problems for folks using Gov Cloud (and aws-cn)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/batch_compute_environment.py
plugins/modules/ec2_launch_template.py
plugins/modules/elasticache_info.py
plugins/modules/iam_group.py
plugins/modules/iam_role.py
plugins/modules/msk_config.py
plugins/modules/redshift.py
plugins/modules/sns_topic.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@tremble tremble deleted the issue/1846 branch September 29, 2023 08:29
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Various ARN handling fixes

Depends-On: ansible-collections/amazon.aws#1619
SUMMARY
fixes: ansible-collections#1846
Various modules had hard-coded ARN handling which assumed the use of the main  partition.  This causes problems for folks using Gov Cloud (and aws-cn)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/batch_compute_environment.py
plugins/modules/ec2_launch_template.py
plugins/modules/elasticache_info.py
plugins/modules/iam_group.py
plugins/modules/iam_role.py
plugins/modules/msk_config.py
plugins/modules/redshift.py
plugins/modules/sns_topic.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@25a636c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Various ARN handling fixes

Depends-On: ansible-collections/amazon.aws#1619
SUMMARY
fixes: ansible-collections#1846
Various modules had hard-coded ARN handling which assumed the use of the main  partition.  This causes problems for folks using Gov Cloud (and aws-cn)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/batch_compute_environment.py
plugins/modules/ec2_launch_template.py
plugins/modules/elasticache_info.py
plugins/modules/iam_group.py
plugins/modules/iam_role.py
plugins/modules/msk_config.py
plugins/modules/redshift.py
plugins/modules/sns_topic.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@25a636c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iam role boundary does not account for gov-cloud
2 participants