Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB - add waiter for secondary indexes #1866

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 2, 2023

SUMMARY

Integration tests keep failing due to concurrency issues (the service doesn't like making updates while index updates are in progress)

Adds a waiter for the indexes

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

dynamodb_table

ADDITIONAL INFORMATION

@tremble tremble added the backport-6 PR should be backported to the stable-6 branch label Jul 2, 2023
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a5825878b1c04401a977e1bb16cef4fc

ansible-galaxy-importer FAILURE in 3m 58s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 32s
✔️ ansible-test-splitter SUCCESS in 4m 37s
integration-community.aws-1 FAILURE in 6m 27s
Skipped 21 jobs

@@ -870,9 +855,6 @@ def _update_table(current_table):
additional_global_index_changes=additional_global_index_changes,
)

if module.params.get("wait"):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, the wait logic is going to be called again in the only place that _update_table() is called.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1a60eaa851c14816b07907d12c038a6d

ansible-galaxy-importer FAILURE in 4m 25s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 38s
✔️ ansible-test-splitter SUCCESS in 5m 20s
integration-community.aws-1 FAILURE in 6m 16s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/8753ed9752bc48cfacdfae59d62458bd

✔️ ansible-galaxy-importer SUCCESS in 3m 33s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 56s
✔️ ansible-test-splitter SUCCESS in 4m 54s
integration-community.aws-1 FAILURE in 6m 41s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d5df853eca78472ca42d40b11d2787b6

ansible-galaxy-importer FAILURE in 4m 04s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-splitter SUCCESS in 4m 50s
integration-community.aws-1 FAILURE in 6m 13s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/41ee6dac1728465fbad6005c16c25886

ansible-galaxy-importer FAILURE in 4m 33s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 39s
✔️ ansible-test-splitter SUCCESS in 4m 59s
integration-community.aws-1 FAILURE in 1h 00m 38s
Skipped 21 jobs

@tremble tremble force-pushed the dynamodb/index_waiter branch 2 times, most recently from 0740783 to 4146cd7 Compare July 3, 2023 19:46
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2b00c61cf8a449cf82a86fc53fe5f777

ansible-galaxy-importer FAILURE in 4m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 34s
✔️ ansible-test-splitter SUCCESS in 5m 07s
✔️ integration-community.aws-1 SUCCESS in 32m 20s
Skipped 21 jobs

@tremble tremble marked this pull request as ready for review July 4, 2023 06:43
@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jul 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/f5ffd5db9c364a4f8ce9945d1aaab05d

ansible-galaxy-importer FAILURE in 4m 04s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 30s
✔️ ansible-test-splitter SUCCESS in 5m 27s
✔️ integration-community.aws-1 SUCCESS in 58m 53s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Required status check "ansible/gate" is expected.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2817da94d902445c862b9309d7ae48c3

✔️ ansible-galaxy-importer SUCCESS in 4m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 17s
✔️ ansible-test-splitter SUCCESS in 4m 51s
✔️ integration-community.aws-1 SUCCESS in 34m 39s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/52dee4e830374c399f21c23a05e647d0

✔️ ansible-galaxy-importer SUCCESS in 4m 12s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 01s
✔️ ansible-test-splitter SUCCESS in 4m 59s
✔️ integration-community.aws-1 SUCCESS in 31m 34s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6fdbd75 into ansible-collections:main Jul 4, 2023
39 checks passed
@patchback
Copy link

patchback bot commented Jul 4, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/6fdbd7532bf0a22c24745881836773d65289e827/pr-1866

Backported as #1870

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 4, 2023
DynamoDB - add waiter for secondary indexes

SUMMARY
Integration tests keep failing due to concurrency issues (the service doesn't like making updates while index updates are in progress)
Adds a waiter for the indexes
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
dynamodb_table
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
(cherry picked from commit 6fdbd75)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 4, 2023
[PR #1866/6fdbd753 backport][stable-6] DynamoDB - add waiter for secondary indexes

This is a backport of PR #1866 as merged into main (6fdbd75).
SUMMARY
Integration tests keep failing due to concurrency issues (the service doesn't like making updates while index updates are in progress)
Adds a waiter for the indexes
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
dynamodb_table
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@tremble tremble deleted the dynamodb/index_waiter branch September 29, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants