Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connection): get bucket_region in aws_ssm #1908

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

Hokwang
Copy link
Contributor

@Hokwang Hokwang commented Aug 8, 2023

SUMMARY

when bucket is in us-east-1,
bucket_location["LocationConstraint"] is null

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

connection

ADDITIONAL INFORMATION

add condition for bucket_region

@ansibullbot
Copy link

@Hokwang this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage new_contributor Help guide this first time contributor small_patch Hopefully easy to review labels Aug 8, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9b9f3b4a54894285a8659b0344f6bc2c

✔️ ansible-galaxy-importer SUCCESS in 3m 44s (non-voting)
✔️ build-ansible-collection SUCCESS in 16m 11s
✔️ ansible-test-splitter SUCCESS in 6m 00s
✔️ integration-community.aws-1 SUCCESS in 10m 38s
✔️ integration-community.aws-2 SUCCESS in 11m 22s
integration-community.aws-3 FAILURE in 17m 08s
Skipped 19 jobs

@0xalex88
Copy link

Is it possible for anyone to review this?
I've encountered the same issue and it took a while to figure out.
In our case the aws client is set to us-west-2 but we're running a playbook on instances in multiple regions (and each of the hosts has ansible_aws_ssm_region correctly set).

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3f4e7a9d6c494a52afdc0f46a0413a84

ansible-galaxy-importer FAILURE in 4m 53s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 31s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-community.aws-1 SUCCESS in 11m 47s
✔️ integration-community.aws-2 SUCCESS in 11m 07s
integration-community.aws-3 FAILURE in 13m 40s
Skipped 19 jobs

when bucket is in us-east-1,
bucket_location["LocationConstraint"] is null
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c41593a6e08f4a6d8840ff1187d02d1b

ansible-galaxy-importer FAILURE in 5m 06s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 58s
✔️ ansible-test-splitter SUCCESS in 6m 09s
✔️ integration-community.aws-1 SUCCESS in 9m 13s
✔️ integration-community.aws-2 SUCCESS in 9m 27s
✔️ integration-community.aws-3 SUCCESS in 10m 18s
✔️ integration-community.aws-4 SUCCESS in 13m 26s
✔️ integration-community.aws-5 SUCCESS in 12m 20s
✔️ integration-community.aws-6 SUCCESS in 18m 52s
✔️ integration-community.aws-7 SUCCESS in 9m 44s
✔️ integration-community.aws-8 SUCCESS in 9m 30s
✔️ integration-community.aws-9 SUCCESS in 10m 12s
✔️ integration-community.aws-10 SUCCESS in 10m 53s
✔️ integration-community.aws-11 SUCCESS in 6m 29s
Skipped 11 jobs

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit this PR, please add a changelog fragment:

https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/eef2789e407c476493b0c98714d09304

✔️ ansible-galaxy-importer SUCCESS in 4m 05s (non-voting)
✔️ build-ansible-collection SUCCESS in 16m 12s
✔️ ansible-test-splitter SUCCESS in 6m 26s
✔️ integration-community.aws-1 SUCCESS in 9m 08s
✔️ integration-community.aws-2 SUCCESS in 10m 29s
✔️ integration-community.aws-3 SUCCESS in 9m 47s
✔️ integration-community.aws-4 SUCCESS in 9m 45s
✔️ integration-community.aws-5 SUCCESS in 10m 20s
✔️ integration-community.aws-6 SUCCESS in 8m 37s
✔️ integration-community.aws-7 SUCCESS in 11m 11s
✔️ integration-community.aws-8 SUCCESS in 10m 38s
✔️ integration-community.aws-9 SUCCESS in 8m 19s
✔️ integration-community.aws-10 SUCCESS in 9m 06s
✔️ integration-community.aws-11 SUCCESS in 5m 16s
Skipped 11 jobs

@tremble tremble added mergeit Merge the PR (SoftwareFactory) and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 11, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/04d6b3d949f0499e9b6f1eba95345a12

✔️ ansible-galaxy-importer SUCCESS in 3m 52s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 58s
✔️ ansible-test-splitter SUCCESS in 5m 24s
✔️ integration-community.aws-1 SUCCESS in 9m 01s
✔️ integration-community.aws-2 SUCCESS in 8m 25s
✔️ integration-community.aws-3 SUCCESS in 9m 19s
✔️ integration-community.aws-4 SUCCESS in 10m 16s
✔️ integration-community.aws-5 SUCCESS in 9m 16s
✔️ integration-community.aws-6 SUCCESS in 9m 16s
✔️ integration-community.aws-7 SUCCESS in 10m 16s
✔️ integration-community.aws-8 SUCCESS in 9m 15s
✔️ integration-community.aws-9 SUCCESS in 8m 20s
✔️ integration-community.aws-10 SUCCESS in 8m 53s
✔️ integration-community.aws-11 SUCCESS in 7m 19s
Skipped 11 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5224601 into ansible-collections:main Jan 11, 2024
39 of 105 checks passed
@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Jan 11, 2024
Copy link

patchback bot commented Jan 11, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/5224601b7cef6510eb12f735ef25d805a605bf15/pr-1908

Backported as #2043

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 11, 2024
fix(connection): get bucket_region in aws_ssm

SUMMARY
when bucket is in us-east-1,
bucket_location["LocationConstraint"] is null
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
connection
ADDITIONAL INFORMATION
add condition for bucket_region

Reviewed-by: Mark Chappell
(cherry picked from commit 5224601)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 11, 2024
[PR #1908/5224601b backport][stable-7] fix(connection): get bucket_region in aws_ssm

This is a backport of PR #1908 as merged into main (5224601).
SUMMARY
when bucket is in us-east-1,
bucket_location["LocationConstraint"] is null
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
connection
ADDITIONAL INFORMATION
add condition for bucket_region

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch bug This issue/PR relates to a bug mergeit Merge the PR (SoftwareFactory) needs_triage new_contributor Help guide this first time contributor small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants