Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Force PyYAML version that can be installed #1917

Merged

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Aug 22, 2023

SUMMARY

Currently integration tests with ansible/ansible-zuul-jobs#1816 still fail when installing some requirements:

2023-08-22 05:53:46.350742 | TASK [ansible-test : Install python requirements]
[...]

2023-08-22 05:53:53.860850 | controller | Collecting PyYAML<5.5,>=3.10 (from awscli->-r /home/zuul-worker/.ansible/collections/ansible_collections/community/aws/test-requirements.txt (line 19))
2023-08-22 05:53:53.866271 | controller |   Downloading PyYAML-5.4.1.tar.gz (175 kB)
2023-08-22 05:53:53.878160 | controller |      �������������������������������������� 175.1/175.1 kB 19.0 MB/s eta 0:00:00
2023-08-22 05:53:54.065094 | controller |   Installing build dependencies: started
2023-08-22 05:53:58.372457 | controller |   Installing build dependencies: finished with status 'done'
2023-08-22 05:53:58.373282 | controller |   Getting requirements to build wheel: started
2023-08-22 05:53:58.680407 | controller |   Getting requirements to build wheel: finished with status 'error'
2023-08-22 05:53:58.689654 | controller |   error: subprocess-exited-with-error

(https://b3e35e76f7fc3e0cf6b5-d430d94f79a1de67219002b64dcf7484.ssl.cf1.rackcdn.com/1904/63f02a9c37ef75f9dcf25159fb4033d6edf146ee/check/integration-community.aws-1/b2f8016/job-output.txt)

Tries to work around this problem by pinning the PyYAML version to 5.3.1 (see also yaml/pyyaml#736).

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

integration tests

@ansibullbot ansibullbot added community_review integration tests/integration needs_triage small_patch Hopefully easy to review tests tests labels Aug 22, 2023
@ansibullbot
Copy link

@ansibullbot ansibullbot added module module plugins plugin (any type) labels Aug 22, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/42731d3ae39e4d4d818db958e57e1110

ansible-galaxy-importer FAILURE in 5m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 38s
✔️ ansible-test-splitter SUCCESS in 5m 23s
integration-community.aws-1 RETRY_LIMIT in 1m 45s
Skipped 21 jobs

@felixfontein
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4fb3c7b2183f43b98ea71c56dfaf76e2

ansible-galaxy-importer FAILURE in 4m 59s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 39s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-community.aws-1 SUCCESS in 7m 08s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6d00e6171f174c798cf814a1ccd3044a

✔️ ansible-galaxy-importer SUCCESS in 4m 27s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 51s
✔️ ansible-test-splitter SUCCESS in 4m 54s
Skipped 22 jobs

softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Aug 22, 2023
CI: Force PyYAML version that can be installed

SUMMARY
Sibling to ansible-collections/community.aws#1917.
ISSUE TYPE

Test Pull Request

COMPONENT NAME
integration tests

Reviewed-by: Mike Graves <[email protected]>
patchback bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Aug 22, 2023
CI: Force PyYAML version that can be installed

SUMMARY
Sibling to ansible-collections/community.aws#1917.
ISSUE TYPE

Test Pull Request

COMPONENT NAME
integration tests

Reviewed-by: Mike Graves <[email protected]>
(cherry picked from commit 7dfdeb3)
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2023
CI: Force PyYAML version that can be installed

SUMMARY
Sibling to ansible-collections/community.aws#1917.
ISSUE TYPE

Test Pull Request

COMPONENT NAME
integration tests

Reviewed-by: Mike Graves <[email protected]>
(cherry picked from commit 7dfdeb3)
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2023
CI: Force PyYAML version that can be installed

SUMMARY
Sibling to ansible-collections/community.aws#1917.
ISSUE TYPE

Test Pull Request

COMPONENT NAME
integration tests

Reviewed-by: Mike Graves <[email protected]>
(cherry picked from commit 7dfdeb3)
@felixfontein felixfontein added backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch labels Aug 23, 2023
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Aug 23, 2023
[PR #1707/7dfdeb3d backport][stable-6] CI: Force PyYAML version that can be installed

This is a backport of PR #1707 as merged into main (7dfdeb3).
SUMMARY
Sibling to ansible-collections/community.aws#1917.
ISSUE TYPE

Test Pull Request

COMPONENT NAME
integration tests

Reviewed-by: Mike Graves <[email protected]>
@felixfontein felixfontein added the mergeit Merge the PR (SoftwareFactory) label Aug 24, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b85f5e8c8fd34e13b4714182c494cae3

ansible-galaxy-importer FAILURE in 5m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 43s
✔️ ansible-test-splitter SUCCESS in 4m 36s
Skipped 22 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 002b139 into ansible-collections:main Aug 24, 2023
118 of 159 checks passed
@patchback
Copy link

patchback bot commented Aug 24, 2023

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 002b139 on top of patchback/backports/stable-5/002b139a2fedc630bd46eadea7e5e2b077a9bb0a/pr-1917

Backporting merged PR #1917 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-5/002b139a2fedc630bd46eadea7e5e2b077a9bb0a/pr-1917 upstream/stable-5
  4. Now, cherry-pick PR CI: Force PyYAML version that can be installed #1917 contents into that branch:
    $ git cherry-pick -x 002b139a2fedc630bd46eadea7e5e2b077a9bb0a
    If it'll yell at you with something like fatal: Commit 002b139a2fedc630bd46eadea7e5e2b077a9bb0a is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 002b139a2fedc630bd46eadea7e5e2b077a9bb0a
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR CI: Force PyYAML version that can be installed #1917 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-5/002b139a2fedc630bd46eadea7e5e2b077a9bb0a/pr-1917
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Aug 24, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/002b139a2fedc630bd46eadea7e5e2b077a9bb0a/pr-1917

Backported as #1918

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the tests branch August 24, 2023 11:14
patchback bot pushed a commit that referenced this pull request Aug 24, 2023
CI: Force PyYAML version that can be installed

SUMMARY
Currently integration tests with ansible/ansible-zuul-jobs#1816 still fail when installing some requirements:
2023-08-22 05:53:46.350742 | TASK [ansible-test : Install python requirements]
[...]

2023-08-22 05:53:53.860850 | controller | Collecting PyYAML<5.5,>=3.10 (from awscli->-r /home/zuul-worker/.ansible/collections/ansible_collections/community/aws/test-requirements.txt (line 19))
2023-08-22 05:53:53.866271 | controller |   Downloading PyYAML-5.4.1.tar.gz (175 kB)
2023-08-22 05:53:53.878160 | controller |      �������������������������������������� 175.1/175.1 kB 19.0 MB/s eta 0:00:00
2023-08-22 05:53:54.065094 | controller |   Installing build dependencies: started
2023-08-22 05:53:58.372457 | controller |   Installing build dependencies: finished with status 'done'
2023-08-22 05:53:58.373282 | controller |   Getting requirements to build wheel: started
2023-08-22 05:53:58.680407 | controller |   Getting requirements to build wheel: finished with status 'error'
2023-08-22 05:53:58.689654 | controller |   error: subprocess-exited-with-error

(https://b3e35e76f7fc3e0cf6b5-d430d94f79a1de67219002b64dcf7484.ssl.cf1.rackcdn.com/1904/63f02a9c37ef75f9dcf25159fb4033d6edf146ee/check/integration-community.aws-1/b2f8016/job-output.txt)
Tries to work around this problem by pinning the PyYAML version to 5.3.1 (see also yaml/pyyaml#736).
ISSUE TYPE

Test Pull Request

COMPONENT NAME
integration tests

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
Reviewed-by: Felix Fontein <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 002b139)
@felixfontein
Copy link
Contributor Author

@alinabuzachis @tremble @markuman thanks a lot for reviewing and your comments!

felixfontein added a commit to felixfontein/community.aws that referenced this pull request Aug 24, 2023
CI: Force PyYAML version that can be installed

SUMMARY
Currently integration tests with ansible/ansible-zuul-jobs#1816 still fail when installing some requirements:
2023-08-22 05:53:46.350742 | TASK [ansible-test : Install python requirements]
[...]

2023-08-22 05:53:53.860850 | controller | Collecting PyYAML<5.5,>=3.10 (from awscli->-r /home/zuul-worker/.ansible/collections/ansible_collections/community/aws/test-requirements.txt (line 19))
2023-08-22 05:53:53.866271 | controller |   Downloading PyYAML-5.4.1.tar.gz (175 kB)
2023-08-22 05:53:53.878160 | controller |      �������������������������������������� 175.1/175.1 kB 19.0 MB/s eta 0:00:00
2023-08-22 05:53:54.065094 | controller |   Installing build dependencies: started
2023-08-22 05:53:58.372457 | controller |   Installing build dependencies: finished with status 'done'
2023-08-22 05:53:58.373282 | controller |   Getting requirements to build wheel: started
2023-08-22 05:53:58.680407 | controller |   Getting requirements to build wheel: finished with status 'error'
2023-08-22 05:53:58.689654 | controller |   error: subprocess-exited-with-error

(https://b3e35e76f7fc3e0cf6b5-d430d94f79a1de67219002b64dcf7484.ssl.cf1.rackcdn.com/1904/63f02a9c37ef75f9dcf25159fb4033d6edf146ee/check/integration-community.aws-1/b2f8016/job-output.txt)
Tries to work around this problem by pinning the PyYAML version to 5.3.1 (see also yaml/pyyaml#736).
ISSUE TYPE

Test Pull Request

COMPONENT NAME
integration tests

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
Reviewed-by: Felix Fontein <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
@felixfontein
Copy link
Contributor Author

I created a manual backport to stable-5 in #1919.

felixfontein added a commit that referenced this pull request Aug 24, 2023
[stable-5] Force PyYAML version that can be installed. (#1917)
felixfontein added a commit that referenced this pull request Aug 24, 2023
…/stable-6/002b139a2fedc630bd46eadea7e5e2b077a9bb0a/pr-1917

[PR #1917/002b139a backport][stable-6] CI: Force PyYAML version that can be installed
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Aug 29, 2023
[manual backport stable-5] Force PyYAML version that can be installed. (#1707)

CI: Force PyYAML version that can be installed
SUMMARY
Sibling to ansible-collections/community.aws#1917. ISSUE TYPE
Test Pull Request
COMPONENT NAME
integration tests
Reviewed-by: Mike Graves [email protected]
(cherry picked from commit 7dfdeb3)
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS
Reviewed-by: Helen Bailey <[email protected]>
krisek pushed a commit to krisek/amazon.aws that referenced this pull request Aug 31, 2023
CI: Force PyYAML version that can be installed

SUMMARY
Sibling to ansible-collections/community.aws#1917.
ISSUE TYPE

Test Pull Request

COMPONENT NAME
integration tests

Reviewed-by: Mike Graves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_triage plugins plugin (any type) small_patch Hopefully easy to review tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants