Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add larger instance types for MSK cluster #1947

Merged
merged 5 commits into from
Jan 11, 2024
Merged

feat: add larger instance types for MSK cluster #1947

merged 5 commits into from
Jan 11, 2024

Conversation

shblue21
Copy link
Contributor

@shblue21 shblue21 commented Sep 15, 2023 •
edited
Loading

This commit adds support for larger instance types (kafka.m5.8xlarge, kafka.m5.12xlarge, kafka.m5.16xlarge, kafka.m5.24xlarge) to the MSK cluster module.
Now users can choose from a wider range of instance sizes when creating an MSK cluster.

If the provisioning MSK supports m6 and m7 in the future, may want to consider removing the choice syntax.
(Provisioning M5 types are not expected to be added anymore, The m5 has a maximum of 24 xlarge types.

SUMMARY

Fixes #1946

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

msk_cluster

ADDITIONAL INFORMATION

Link to MSK Provisioning Instance Types documentation

@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/037e5417a3d24f5fb84d581d6b3599cf

✔️ ansible-galaxy-importer SUCCESS in 3m 56s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-splitter SUCCESS in 5m 03s
✔️ integration-community.aws-1 SUCCESS in 44m 58s
❌ integration-community.aws-2 TIMED_OUT in 1h 00m 46s
Skipped 20 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/0a2f87d344544775a60419c8d6d660aa

✔️ ansible-galaxy-importer SUCCESS in 9m 41s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 22s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-community.aws-1 SUCCESS in 48m 14s
❌ integration-community.aws-2 TIMED_OUT in 1h 00m 45s
Skipped 20 jobs

@shblue21
Copy link
Contributor Author

shblue21 commented Oct 5, 2023 •
edited
Loading

Hello.
This is a very simple code that only adds an array value of kafka broker instances, but it is causing a timeout when testing zuul.

I checked the logfile and it seems to be because it takes almost 40 minutes to create the MSK cluster.

...
2023-09-29 13:03:16.507100 | controller | TASK [msk_cluster : create msk cluster] ****************************************
2023-09-29 13:03:16.507104 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/msk_cluster/tasks/test_create.yml:22
2023-09-29 13:40:30.825754 | controller | Using module file /home/zuul/.ansible/collections/ansible_collections/community/aws/plugins/modules/msk_cluster.py
2023-09-29 13:40:30.825785 | controller | Pipelining is enabled.
2023-09-29 13:40:30.825790 | controller | <testhost> ESTABLISH LOCAL CON
...

Is it possible to pass the test manually?
Or if you need to refactor the msk_cluster testcode, I can work on it.

@shblue21
feat: add larger instance types for MSK cluster
e406874 
This commit adds support for larger instance types (kafka.m5.8xlarge, kafka.m5.12xlarge, kafka.m5.16xlarge, kafka.m5.24xlarge) to the MSK cluster module. Now users can choose from a wider range of instance sizes when creating an MSK cluster.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6b1da59cb26445f58abd72ed76da81e9

❌ ansible-galaxy-importer FAILURE in 5m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 50s
✔️ ansible-test-splitter SUCCESS in 5m 50s
✔️ integration-community.aws-1 SUCCESS in 46m 00s
✔️ integration-community.aws-2 SUCCESS in 52m 15s
Skipped 20 jobs

alinabuzachis
alinabuzachis reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please add a changelog fragment?

plugins/modules/msk_cluster.py Show resolved Hide resolved
@tremble tremble added mergeit Merge the PR (SoftwareFactory) backport-7 PR should be backported to the stable-7 branch labels Jan 11, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/779d562efb1542baa4da0cd80fd6fe1b

❌ ansible-galaxy-importer FAILURE in 5m 22s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 00s
✔️ ansible-test-splitter SUCCESS in 5m 54s
✔️ integration-community.aws-1 SUCCESS in 35m 08s
✔️ integration-community.aws-2 SUCCESS in 45m 20s
Skipped 20 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2b5d71d into ansible-collections:main Jan 11, 2024
66 of 73 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 11, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/2b5d71d8ad9d5711318cb58bfb7ead148782a059/pr-1947

Backported as #2045

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 11, 2024
@shblue21 @patchback
feat: add larger instance types for MSK cluster (#1947)
22050fb 
feat: add larger instance types for MSK cluster

This commit adds support for larger instance types (kafka.m5.8xlarge, kafka.m5.12xlarge, kafka.m5.16xlarge, kafka.m5.24xlarge) to the MSK cluster module.
Now users can choose from a wider range of instance sizes when creating an MSK cluster.
If the provisioning MSK supports m6 and m7 in the future, may want to consider removing the choice syntax.
(Provisioning M5 types are not expected to be added anymore, The m5 has a maximum of 24 xlarge types.
SUMMARY

Fixes #1946
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

msk_cluster
ADDITIONAL INFORMATION

Link to MSK Provisioning Instance Types documentation

https://docs.aws.amazon.com/msk/latest/developerguide/msk-create-cluster.html#broker-instance-types

Reviewed-by: Alina Buzachis
Reviewed-by: JIHUN KIM <[email protected]>
Reviewed-by: Mark Chappell
(cherry picked from commit 2b5d71d)
@patchback patchback bot mentioned this pull request Jan 11, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 11, 2024
@patchback
feat: add larger instance types for MSK cluster (#1947) (#2045)
9e892b0 
[PR #1947/2b5d71d8 backport][stable-7] feat: add larger instance types for MSK cluster

This is a backport of PR #1947 as merged into main (2b5d71d).
This commit adds support for larger instance types (kafka.m5.8xlarge, kafka.m5.12xlarge, kafka.m5.16xlarge, kafka.m5.24xlarge) to the MSK cluster module.
Now users can choose from a wider range of instance sizes when creating an MSK cluster.
If the provisioning MSK supports m6 and m7 in the future, may want to consider removing the choice syntax.
(Provisioning M5 types are not expected to be added anymore, The m5 has a maximum of 24 xlarge types.
SUMMARY


Fixes #1946
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

msk_cluster
ADDITIONAL INFORMATION


Link to MSK Provisioning Instance Types documentation

https://docs.aws.amazon.com/msk/latest/developerguide/msk-create-cluster.html#broker-instance-types

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis left review comments

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add an MSK broker instance type
3 participants
@shblue21 @tremble @alinabuzachis