Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for G.4X and G.8X in glue_job.py #2048

Merged

Conversation

randomnaja
Copy link
Contributor

SUMMARY

according to https://aws.amazon.com/about-aws/whats-new/2023/05/aws-glue-large-instance-types-generally-available/ I added support for these 2 new instance types

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

glue_job

Copy link

github-actions bot commented Jan 19, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ac445b6f6f574e3d9d6d9dc54db850f5

✔️ ansible-galaxy-importer SUCCESS in 3m 52s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 15s
✔️ ansible-test-splitter SUCCESS in 5m 20s
✔️ integration-community.aws-1 SUCCESS in 21m 05s
✔️ integration-community.aws-2 SUCCESS in 6m 41s
Skipped 20 jobs

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit this PR.

Please add a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#making-your-pr-merge-worthy

plugins/modules/glue_job.py Outdated Show resolved Hide resolved
@randomnaja
Copy link
Contributor Author

Thanks for taking the time to submit this PR.

Please add a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#making-your-pr-merge-worthy

I added changelog fragment

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/39d6069f2b4043e7a98ae9c6881b9980

✔️ ansible-galaxy-importer SUCCESS in 4m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 17m 43s
✔️ ansible-test-splitter SUCCESS in 6m 28s
✔️ integration-community.aws-1 SUCCESS in 6m 58s
Skipped 21 jobs

@alinabuzachis alinabuzachis added the backport-7 PR should be backported to the stable-7 branch label Mar 1, 2024
@alinabuzachis alinabuzachis added this to the 7.2.0 milestone Mar 1, 2024
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/00bb200a507646acbfe6d928255d7260

ansible-galaxy-importer FAILURE in 5m 18s (non-voting)
✔️ build-ansible-collection SUCCESS in 16m 06s
✔️ ansible-test-splitter SUCCESS in 6m 19s
✔️ integration-community.aws-1 SUCCESS in 21m 32s
✔️ integration-community.aws-2 SUCCESS in 6m 32s
Skipped 20 jobs

@randomnaja
Copy link
Contributor Author

Is there any progress on merging this PR ?

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 25, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e10586cdc4374058ae66fdae0dfedc6c

ansible-galaxy-importer FAILURE in 5m 27s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 30s
✔️ ansible-test-splitter SUCCESS in 6m 21s
✔️ integration-community.aws-1 SUCCESS in 6m 52s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a397c4c into ansible-collections:main Mar 25, 2024
34 of 41 checks passed
Copy link

patchback bot commented Mar 25, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/a397c4c324c7c705648a9a056a1e60f5de6c93f4/pr-2048

Backported as #2060

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 25, 2024
add support for G.4X and G.8X in glue_job.py

SUMMARY
according to https://aws.amazon.com/about-aws/whats-new/2023/05/aws-glue-large-instance-types-generally-available/ I added support for these 2 new instance types
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
glue_job

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
(cherry picked from commit a397c4c)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 25, 2024
[PR #2048/a397c4c3 backport][stable-7] add support for G.4X and G.8X in glue_job.py

This is a backport of PR #2048 as merged into main (a397c4c).
SUMMARY
according to https://aws.amazon.com/about-aws/whats-new/2023/05/aws-glue-large-instance-types-generally-available/ I added support for these 2 new instance types
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
glue_job

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants