AWS ELB: Return empty list when no load balancer name was found #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjrm
force-pushed
the
aws_return_empty_list
branch
from
1e256fd
to
707825d
Compare
tremble
reviewed
Sep 11, 2020
|
Hi @pjrm thanks for taking the time to raise this PR. I'm not 100% on what behaviour we're want here so I'd like hear from at least @jillr, although as authors of this module @mjschultz and @nand0p could also chime in. |
tremble
requested changes
Sep 11, 2020
There was a problem hiding this comment.
Thanks for your contribution here.
In general I think this is the right change but we'd like a couple of extra pieces before we merge this.
- Please add a 'minor_changes' changelog entry: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
- We need at least some basic integration testing for the module
- Please update the integration tests in tests/integration/targets/elb_classic_lb/tasks/main.yml to include at least some basic testing for this usecase and a minimal 'standard' use case.
- Then add
elb_classic_lb_infoto tests/integration/targets/elb_classic_lb/aliases - While going the whole hog and adding elb_classic_lb_info calls and assertions after all/most elb_classic_lb calls would be nice, I appreciate that does take time and would be happy with just one for the 'an LB exists' use case and one for the 'no LBs exist' use case.
If you need any help getting these changes added you can find us on IRC (freenode: #ansible-aws) or just ask here.
ansibullbot
added
affects_2.10
bug
|
Hi, you tried to reach out on IRC but unfortunately I was in meetings. Feel free to ask your question on here or in #ansible-aws there's a couple of other folks who may also be able to help. |
pjrm
force-pushed
the
aws_return_empty_list
branch
from
707825d
to
709b860
Compare
|
Hi @tremble, Thank you very much for the feedback. I already provided the requested changes. |
pjrm
added a commit
to pjrm/aws-terminator
that referenced
this pull request
Feb 16, 2021
This permission is needed to use the classic elb_classic_info module on elb_classic integration tests (ansible-collections/community.aws#215).
This was referenced Feb 16, 2021
tremble
approved these changes
Mar 14, 2021
|
@pjrm this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
tremble
force-pushed
the
aws_return_empty_list
branch
from
08797e4
to
568f746
Compare
ansibullbot
removed
merge_commit
When trying to describe a LoadBalancer that doesn't exist, the module crash. Instead of that behavior, this commit will return an empty list when no load balancer is found, allowing to deal next tasks by reading the output of the module.
tremble
force-pushed
the
aws_return_empty_list
branch
from
568f746
to
c00e353
Compare
|
Hi @pjrm thanks for your submission. Sorry it's taken so long to get this merged. |
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
…ble-collections#215) When trying to describe a LoadBalancer that doesn't exist, the module crash. Instead of that behavior, this commit will return an empty list when no load balancer is found, allowing to deal next tasks by reading the output of the module. Co-authored-by: Pedro Magalhães <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ble-collections#215) When trying to describe a LoadBalancer that doesn't exist, the module crash. Instead of that behavior, this commit will return an empty list when no load balancer is found, allowing to deal next tasks by reading the output of the module. Co-authored-by: Pedro Magalhães <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ble-collections#215) When trying to describe a LoadBalancer that doesn't exist, the module crash. Instead of that behavior, this commit will return an empty list when no load balancer is found, allowing to deal next tasks by reading the output of the module. Co-authored-by: Pedro Magalhães <[email protected]>
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…ble-collections#215) When trying to describe a LoadBalancer that doesn't exist, the module crash. Instead of that behavior, this commit will return an empty list when no load balancer is found, allowing to deal next tasks by reading the output of the module. Co-authored-by: Pedro Magalhães <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* ec2_vol support for gp3 volume * fix sanity checks * fix reference before assignment * fix integration test * None compare will alway result in True * introduce new parameter 'modify_volume' to keep backwards compatibility * fix output and expand integration test * remove unused key * fix integration test * introduce throughput and fix ci * try latest boto3 * rework boto3 requirements for integration test * add botocode and coverage * boto is also required * add changelog fragment * change version added * change version to majo * change description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to describe a LoadBalancer that doesn't exist, the module crash. Instead of that behavior, this commit will return an empty list when no load balancer is found, allowing to deal next tasks by reading the output of the module.
ISSUE TYPE
COMPONENT NAME
plugins/modules/elb_classic_lb_info.py