Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoscaling_instance_refresh - prepare modules for promotion #2150

Merged
merged 8 commits into from
Sep 25, 2024
Merged

autoscaling_instance_refresh - prepare modules for promotion #2150

merged 8 commits into from
Sep 25, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Sep 20, 2024 •
edited
Loading

SUMMARY

Closes #2120
Closes #2019
Closes #2016

Prepare modules autoscaling_instance_refresh and autoscaling_instance_refresh_info for promotion:

  • Refactor modules to use common code from ansible_collections.amazon.aws.plugins.module_utils.autoscaling
  • Add type hinting
  • Update integration tests
ISSUE TYPE
  • Feature Pull Request

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1540c9bf69d94065b940a53da2e12675

✔️ ansible-galaxy-importer SUCCESS in 3m 42s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 39s
✔️ ansible-test-splitter SUCCESS in 6m 17s
✔️ integration-community.aws-1 SUCCESS in 12m 48s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/aa5b9cfcb1834c95b246c1a6fac582f0

❌ ansible-galaxy-importer FAILURE in 5m 14s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 39s
✔️ ansible-test-splitter SUCCESS in 4m 25s
✔️ integration-community.aws-1 SUCCESS in 16m 31s
Skipped 21 jobs

GomathiselviS
GomathiselviS reviewed Sep 20, 2024
View reviewed changes
plugins/modules/autoscaling_instance_refresh.py Outdated Show resolved Hide resolved
plugins/modules/autoscaling_instance_refresh.py Outdated Show resolved Hide resolved
plugins/modules/autoscaling_instance_refresh.py Outdated Show resolved Hide resolved
plugins/modules/autoscaling_instance_refresh.py Outdated Show resolved Hide resolved
plugins/modules/autoscaling_instance_refresh.py Outdated Show resolved Hide resolved
plugins/modules/autoscaling_instance_refresh.py Outdated Show resolved Hide resolved
plugins/modules/autoscaling_instance_refresh.py Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7569f12c7f5949c890bfe1086e7c2209

✔️ ansible-galaxy-importer SUCCESS in 3m 26s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 41s
✔️ ansible-test-splitter SUCCESS in 4m 20s
✔️ integration-community.aws-1 SUCCESS in 16m 34s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b9e4a79751a54146887c1029cd11ae82

❌ ansible-galaxy-importer FAILURE in 4m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 43s
✔️ ansible-test-splitter SUCCESS in 4m 20s
✔️ integration-community.aws-1 SUCCESS in 19m 31s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a01904281f6646f38292999f4d9ed532

❌ ansible-galaxy-importer FAILURE in 4m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 49s
✔️ ansible-test-splitter SUCCESS in 4m 21s
✔️ integration-community.aws-1 SUCCESS in 14m 47s
Skipped 21 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Sep 25, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/556a3db2ee394009ae02fd7c36c22e3d

❌ ansible-galaxy-importer FAILURE in 4m 43s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 53s
✔️ ansible-test-splitter SUCCESS in 4m 18s
✔️ integration-community.aws-1 SUCCESS in 14m 03s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d59fa93 into ansible-collections:main Sep 25, 2024
67 checks passed
alinabuzachis pushed a commit to GomathiselviS/community.aws that referenced this pull request Oct 1, 2024
@abikouo @alinabuzachis
autoscaling_instance_refresh - prepare modules for promotion (ansible…
1790f0c 
…-collections#2150)

SUMMARY
Closes ansible-collections#2120
Closes ansible-collections#2019
Closes ansible-collections#2016
Prepare modules autoscaling_instance_refresh and autoscaling_instance_refresh_info for promotion:

Refactor modules to use common code from ansible_collections.amazon.aws.plugins.module_utils.autoscaling
Add type hinting
Update integration tests


ISSUE TYPE


Feature Pull Request

Reviewed-by: GomathiselviS
Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
@abikouo abikouo deleted the autoscalling_refactor_v1 branch October 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GomathiselviS GomathiselviS GomathiselviS approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@mandar242 mandar242 Awaiting requested review from mandar242

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
3 participants
@abikouo @alinabuzachis @GomathiselviS