Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gather information about ASG lifecycle hooks #233

Merged
merged 3 commits into from
Mar 14, 2021
Merged

Gather information about ASG lifecycle hooks #233

merged 3 commits into from
Mar 14, 2021

Conversation

salehabbas
Copy link
Contributor

SUMMARY

Amazon EC2 Auto Scaling lifecycle hooks are part of an AWS ASG. This change include them in the ASG description. They are not returned as part of the describe_auto_scaling_groups API call. I am adding them by calling describe_lifecycle_hooks API call.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
plugins/modules/ec2_asg_facts.py

@ansibullbot
Copy link

cc @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added affects_2.10 community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 18, 2020
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Nov 16, 2020
@goneri
Copy link
Member

goneri commented Feb 19, 2021

Hi @salehabbas,

Can you please add a changelog fragment to your PR ( https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs ). It would also be great if you can adjust the existing test-suite to cover this new use-case. If you need help, don't hesitate to ping us on IRC.

@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Mar 14, 2021
tremble
tremble requested changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's preferred to use "fail_json_aws" which knows how to properly format the Boto3 exceptions. The ASG tests are currently broken so I think we can skip the requirement for an integration test, and I've tested locally

plugins/modules/ec2_asg_info.py Outdated Show resolved Hide resolved
tremble
tremble approved these changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission.

The ASG integration tests are currently slow and broken, and I've tested locally.

@tremble tremble merged commit 7c1b49f into ansible-collections:main Mar 14, 2021
@tremble
Copy link
Contributor

tremble commented Mar 14, 2021

Hi @salehabbas,

thanks for taking the time to submit this PR. I'm sorry it's taken so long to get everything merged.

danquixote pushed a commit to danquixote/community.aws that referenced this pull request May 16, 2021
@salehabbas @tremble @danquixote
Gather information about ASG lifecycle hooks (ansible-collections#233)
c9d0845 
* Gather information about ASG lifecycle hooks for community.aws.ec2_asg_info
* add a changelog fragment to the change
* use fail_json_aws

Co-authored-by: Saleh Abbas <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@salehabbas @tremble
Gather information about ASG lifecycle hooks (ansible-collections#233)
73e0c95 
* Gather information about ASG lifecycle hooks for community.aws.ec2_asg_info
* add a changelog fragment to the change
* use fail_json_aws

Co-authored-by: Saleh Abbas <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@salehabbas @tremble
Gather information about ASG lifecycle hooks (ansible-collections#233)
342bf40 
* Gather information about ASG lifecycle hooks for community.aws.ec2_asg_info
* add a changelog fragment to the change
* use fail_json_aws

Co-authored-by: Saleh Abbas <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@salehabbas @tremble @danielcotton
Gather information about ASG lifecycle hooks (ansible-collections#233)
ebff9ce 
* Gather information about ASG lifecycle hooks for community.aws.ec2_asg_info
* add a changelog fragment to the change
* use fail_json_aws

Co-authored-by: Saleh Abbas <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
affects_2.10 feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salehabbas @ansibullbot @goneri @tremble