Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinesis_stream: Don't mark kstreams changed when no encryption actions taken #27

Merged
merged 12 commits into from
Mar 31, 2021
Merged

kinesis_stream: Don't mark kstreams changed when no encryption actions taken #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
060411c
fix: Don't mark kstreams `changed` when no encryption actions taken
Apr 7, 2020
1dcefd8
doc: add changelog fragment
Tyler-2 Aug 20, 2020
9eba1b9
Move disable_stream_encryption test to integration test
tremble Mar 13, 2021
14981b8
Update descriptions/fetch calls to still run on check_mode
tremble Mar 13, 2021
132831c
use standard helpers to convert tags to/from boto3 format
tremble Mar 13, 2021
bad6792
use camel_dict_to_snake_dict helper
tremble Mar 13, 2021
f546894
use standard compare_aws_tags helper
tremble Mar 13, 2021
1b4b3f4
Fix tag handling and use standard helpers
tremble Mar 13, 2021
b291f4b
Format results and add tags when manipulating encryption settings
tremble Mar 13, 2021
6daa6d2
Move kinesis_stream tests over to just integration tests
tremble Mar 13, 2021
39990f6
changelog
tremble Mar 13, 2021
29fe3b0
lint
tremble Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelogs/fragments/23-kinesis_stream-changed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
minor_changes:
- kinesis_stream - now returns tags consistently (https://github.com/ansible-collections/community.aws/pull/27).
- kinesis_stream - now returns changed more accurately (https://github.com/ansible-collections/community.aws/pull/27).
- kinesis_stream - return values are now the same format when working with both encrypted and un-encrypted streams (https://github.com/ansible-collections/community.aws/pull/27).
- kinesis_stream - check_mode is now based on the live settings rather than comparisons with a hard coded/fake stream definition (https://github.com/ansible-collections/community.aws/pull/27).
2 changes: 2 additions & 0 deletions changelogs/fragments/27-kinesis_stream-do-not-mark-as-changed-no-enc-actions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- kinesis_stream - fixed issue where streams get marked as changed even if no encryption actions were necessary (https://github.com/ansible/ansible/issues/65928).
Loading