Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_eip - Formally deprecate the 'instance_id' alias. #349

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 8, 2021

SUMMARY

We've been issuing a warning for a while, formally deprecate it so we
can start cleaning up the code.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_eip

ADDITIONAL INFORMATION

We've been issuing a warning for a while, formally deprecate it so we
can start cleaning up the code.
@tremble tremble force-pushed the cleanup/ec2_eip/instance_id branch from d7de435 to e4ceb18 Compare January 8, 2021 12:35
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jan 13, 2021
@tremble
Copy link
Contributor Author

tremble commented Jan 13, 2021

Community Review and Author review. Merging

@tremble tremble merged commit 384af18 into ansible-collections:main Jan 13, 2021
@tremble tremble deleted the cleanup/ec2_eip/instance_id branch February 11, 2021 09:26
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…tions#349)

* ec2_eip - Formally deprecate the 'instance_id' alias.

We've been issuing a warning for a while, formally deprecate it so we
can start cleaning up the code.
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…tions#349)

* ec2_eip - Formally deprecate the 'instance_id' alias.

We've been issuing a warning for a while, formally deprecate it so we
can start cleaning up the code.
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
…tions#349)

* ec2_eip - Formally deprecate the 'instance_id' alias.

We've been issuing a warning for a while, formally deprecate it so we
can start cleaning up the code.
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…tions#349)

* ec2_eip - Formally deprecate the 'instance_id' alias.

We've been issuing a warning for a while, formally deprecate it so we
can start cleaning up the code.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@384af18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants