aws_ssm signed url using v2 and thus aws_ssm generates incompatible curl request to download s3 object for ansible python #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
reviewed
Jan 11, 2021
plugins/connection/aws_ssm.py
Outdated
| if self.get_option('region') is None: | ||
| region_name = 'us-east-1' | ||
| else: | ||
| region_name = self.get_option('region') |
There was a problem hiding this comment.
You can actually just do, and this will also cover the case where the region is an empty string:
region_name = self.get_option('region') or 'us-east-1'There was a problem hiding this comment.
This has been addressed with the new commits.
goneri
suggested changes
Jan 11, 2021
There was a problem hiding this comment.
Thank you for the Pull Request. We need a changelog fragment before we can merge it. Can you please add one? https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs
…ansible playbook usingh aws_ssm
Change log set has been updated and pushed. |
ansibullbot
added
bug
goneri
approved these changes
Jan 13, 2021
|
Thank you @ramvalleru for your contribution :-). |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…url request to download s3 object for ansible python (ansible-collections#352) - AWS SDKs that were released before May 2016, request Signature Version 4 - fix generated url for aws s3 object for ansible python that executes ansible playbook usingh aws_ssm
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…url request to download s3 object for ansible python (ansible-collections#352) - AWS SDKs that were released before May 2016, request Signature Version 4 - fix generated url for aws s3 object for ansible python that executes ansible playbook usingh aws_ssm
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…url request to download s3 object for ansible python (ansible-collections#352) - AWS SDKs that were released before May 2016, request Signature Version 4 - fix generated url for aws s3 object for ansible python that executes ansible playbook usingh aws_ssm
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Correct changelog data from 1.4.1 Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Issue is with botocore which still uses V2 signature by default instead of V4 signature. This result in malformed CURL http url to download Ansible python script from S3. Issue is documented in botocore boto/botocore#2109.
Include fix to #351
ISSUE TYPE
COMPONENT NAME
aws_ssm connection
ADDITIONAL INFORMATION