ec2_vpc_endpoint - fixup deletion 'changed' #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return not changed when state=absent and endpoint has already been deleted
ansibullbot
added
bug
tremble
force-pushed
the
vpc_endpoint/deletion
branch
from
933f332
to
be83c74
Compare
ansibullbot
added
community_review
and removed
needs_revision
jillr
approved these changes
Feb 12, 2021
ethemcemozkan
pushed a commit
to ethemcemozkan/community.aws
that referenced
this pull request
Feb 18, 2021
* Ensure ec2_vpc_endpoint returns True when deleting an Endpoint Return not changed when state=absent and endpoint has already been deleted * Add minimal endpoint tests
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…tions#362) * Ensure ec2_vpc_endpoint returns True when deleting an Endpoint Return not changed when state=absent and endpoint has already been deleted * Add minimal endpoint tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@a89ec90
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Ensure ec2_vpc_endpoint returns True when deleting an Endpoint Return not changed when state=absent and endpoint has already been deleted * Add minimal endpoint tests
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Ensure ec2_vpc_endpoint returns True when deleting an Endpoint Return not changed when state=absent and endpoint has already been deleted * Add minimal endpoint tests
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* Ensure ec2_vpc_endpoint returns True when deleting an Endpoint Return not changed when state=absent and endpoint has already been deleted * Add minimal endpoint tests
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…s#362) Migrates scenario guide from ansible/ansible repo SUMMARY Related to ansible-community/antsibull#255. Do we need to rename the page index.rst? Or add an index.rst file? Also needs a PR against ansible/ansible removing this content from there. ISSUE TYPE Docs Pull Request COMPONENT NAME docs.ansible.com Depends-On: ansible/ansible-zuul-jobs#962 Reviewed-by: Mark Chappell <None> Reviewed-by: Alicia Cozine <None> Reviewed-by: Jill R <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* Ensure ec2_vpc_endpoint returns True when deleting an Endpoint Return not changed when state=absent and endpoint has already been deleted * Add minimal endpoint tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@a89ec90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently changed is always
Falsewhen deleting an endpoint and deleting an already deleted endpoint results in an exception/Minimal tests for creation/deletion included. RTBs are created but not yet used in tests because I started writing tests and hitting bugs. I want to make sure the changes can be followed and easily reviewed.
More tests to follow
ISSUE TYPE
COMPONENT NAME
ec2_vpc_endpoint
ec2_vpc_endpoint_info
ADDITIONAL INFORMATION
ec2_vpc_endpoint currently uses boto's check mode to test for check_mode, this only tests permissions not changes.