Make iam module more predictable and idempotent … #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_name it creates/deletes
ansibullbot
added
bug
|
@stefanhorning thank you for the PR. Could you add changelog fragment? |
|
@gravesm done. |
gravesm
approved these changes
Mar 22, 2021
tremble
requested changes
Mar 24, 2021
There was a problem hiding this comment.
The PR/Issue should be linked to in the changelog fragment, this helps folks digging into changes that might have introduced bugs or behaviour changes.
I would generally say that idempotency is more about a lack of "changed" (and not actually making a change) rather than a different return value.
|
Thanks for your PR. I'm sorry it's taking so long to get through these reviews. Just a minor niggle |
ansibullbot
added
needs_revision
Co-authored-by: Mark Chappell <[email protected]>
|
@tremble done |
tremble
approved these changes
Mar 24, 2021
tremble
approved these changes
Mar 24, 2021
|
Thanks @stefanhorning |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…s#369) * Make iam module more predictable and idempotent on returning the user_name it creates/deletes * Add changelog fragment for iam module change
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…s#369) * Make iam module more predictable and idempotent on returning the user_name it creates/deletes * Add changelog fragment for iam module change
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…s#369) * Make iam module more predictable and idempotent on returning the user_name it creates/deletes * Add changelog fragment for iam module change
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ections#369) Update README with new python and botocore requirements Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on returning the user_name it creates/deletes
SUMMARY
Currently dependending on what the module does (create/update/delete) one has to find the returned user_name in different places (or it won't be returned at all). To make this behaviour more consistent, this patch makes sure that the user name is always returned under the
user_namekey.ISSUE TYPE
COMPONENT NAME
iam.py
ADDITIONAL INFORMATION
I have gist here with a playbook showcasing the issue: https://gist.github.com/stefanhorning/a948b9f63a5db8a2a38fc988080a13b2
Run it without my patch and you will get arbitrary output (defined/undefined) for the user_name param. Run it with my patch and it will behave predictably and consistent.