Added 'worker_type' and 'glue_version' attributes to the module #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
RD89
approved these changes
Jan 25, 2021
ansibullbot
added
community_review
and removed
needs_revision
|
@vijayanandsharma thank you for the PR. Before we can merge this could you add a changelog fragment? |
tremble
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Thanks for adding the change-log entry.
A couple of minor issues that I'll merge.
Something which would be really appreciated would be if you could add some integration tests for aws_glue_job. They live in tests/integration/targets/<module_name> and are just Ansible roles. It's much better when someone who's familiar with the service writes them. Given there aren't any integration tests for aws_glue_job I don't think it's fair to require them to get this PR merged.
tremble
approved these changes
Mar 29, 2021
|
Many thanks for taking the time to open this PR. I'm sorry it's taken so long to get it reviewed and merged. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ble-collections#370) * Added 'worker_type' and 'glue_version' attributes to the module * fix: fixed compare_glue_job_params to compare the new attributes * Added changelog - fragments * Minor docs tweaks
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ble-collections#370) * Added 'worker_type' and 'glue_version' attributes to the module * fix: fixed compare_glue_job_params to compare the new attributes * Added changelog - fragments * Minor docs tweaks
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…ble-collections#370) * Added 'worker_type' and 'glue_version' attributes to the module * fix: fixed compare_glue_job_params to compare the new attributes * Added changelog - fragments * Minor docs tweaks
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…#370) Improve state and config changes in ec2_instance Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support to
glue_versionandworker_typeattributes in the Glue ModuleISSUE TYPE
COMPONENT NAME
aws_glue_job.py