Cleanup lambda_alias #396
Merged
Cleanup lambda_alias #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jillr @pjodouin @ryansb @s-hertel @wimnat |
ansibullbot
added
feature
tremble
force-pushed
the
cleanup/lambda_alias
branch
from
d7b3a28
to
5c8b264
Compare
ansibullbot
added
community_review
and removed
needs_revision
|
@jillr Not sure why rerunning the tests didn't originally work, I'm guessing IAM was being slow to roll out the new policy. I've rebased and repushed and that seems to have fixed the tests. |
…apped) boto3 connection
tremble
force-pushed
the
cleanup/lambda_alias
branch
from
5c8b264
to
c76aee6
Compare
jillr
approved these changes
Feb 19, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Update lambda_alias to use AnsibleAWSModule.client * Update lambda_alias to use fail_json_aws * Replace custom snake/camel conversion * lambda_alias replace use of AWSConnection with passing a standard (wrapped) boto3 connection * Enable Retries * Fix idempotency when description isn't set. * Don't throw an exception when attempting to create a new alias in check mode * Add revision_id to return docs * Add integration tests * add changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Update lambda_alias to use AnsibleAWSModule.client * Update lambda_alias to use fail_json_aws * Replace custom snake/camel conversion * lambda_alias replace use of AWSConnection with passing a standard (wrapped) boto3 connection * Enable Retries * Fix idempotency when description isn't set. * Don't throw an exception when attempting to create a new alias in check mode * Add revision_id to return docs * Add integration tests * add changelog
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* Update lambda_alias to use AnsibleAWSModule.client * Update lambda_alias to use fail_json_aws * Replace custom snake/camel conversion * lambda_alias replace use of AWSConnection with passing a standard (wrapped) boto3 connection * Enable Retries * Fix idempotency when description isn't set. * Don't throw an exception when attempting to create a new alias in check mode * Add revision_id to return docs * Add integration tests * add changelog
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Update lambda_alias to use AnsibleAWSModule.client * Update lambda_alias to use fail_json_aws * Replace custom snake/camel conversion * lambda_alias replace use of AWSConnection with passing a standard (wrapped) boto3 connection * Enable Retries * Fix idempotency when description isn't set. * Don't throw an exception when attempting to create a new alias in check mode * Add revision_id to return docs * Add integration tests * add changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@38709e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
lambda_alias
ADDITIONAL INFORMATION
depends on mattclay/aws-terminator#123