Fix parameter validation in ecs_task

[mjmayer]

SUMMARY

Fixes incorrect logic in parameter validation.

if 'task_definition' not in module.params and module.params['task_definition'] is None:
    module.fail_json(msg="To stop a task, a task definition must be specified")

This will not evaluate to true even if task_definition not provided because module.params['task_definiton'] = None by default. Which means the condition 'task_definition' not in module.params is always false.

Fixes #401

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ecs_task

[ansibullbot]

cc @Java1Guy @jillr @s-hertel @tremble @wimnat
click here for bot help

[tremble]

Thanks for this PR.

I think it would be good to add a couple of entries to the operation description (line 21)

- When I(operation=start) both I(task_definition) and I(container_instances) must be set.
- When I(operation=stop) both I(task_definition) and I(task) must be set.

Integration tests would also be a nice-to-have, but since they seem to be completely missing right now it's totally reasonable for you not to add them.

[tremble]

As a future thing, I find using a temporary variable (same as we do with argument_spec) preferable to the way you split required_if to stay within 80 chars. In this case it would have allowed you to group things a little more clearly. But that's a personal style thing.

Thanks for fixing this.

[markuman]

LGTM

[tremble]

Thanks for taking the time to submit this PR. The fix should be available in version 1.4.0 which we expect to release in the near future.