ec2_vpc_nat_gateway move describe_addresses call back to non-paginated #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillr
approved these changes
Feb 24, 2021
ansibullbot
added
bug
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…ion not supported) (ansible-collections#441) This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2fe5c31
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…s#429) Disable ec2_key, ec2_snapshot and ec2_group tests SUMMARY Work around ansible-collections#428 and ansible-collections#440 ansible-collections#441 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_key ec2_snapshot ec2_group ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: None <None> Reviewed-by: Paul Belanger <None> Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…pported) (ansible-collections#441) This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2fe5c31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In #427 the describe_addresses call was mistakenly moved to a paginated lookup. boto3 currently doesn't support pagination on describe_addresses
Issue isn't in a released version yet, so changelog isn't needed
ISSUE TYPE
COMPONENT NAME
ec2_vpc_nat_gateway
ADDITIONAL INFORMATION