More no_log changes #471
Merged
More no_log changes #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
approved these changes
Mar 12, 2021
markuman
approved these changes
Mar 12, 2021
This was referenced Mar 12, 2021
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
* More no_log changes * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* More no_log changes * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* More no_log changes * changelog
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* More no_log changes * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
secretparameter contains sensitive data and shouldn't be logged.key_prefixmatches 'key' so triggers a false positive with the latest sanity testsISSUE TYPE
COMPONENT NAME
s3_sync
aws_secret
ADDITIONAL INFORMATION
Thanks to @felixfontein for the heads up
ansible/ansible#73508