ec2_vpc_nat_gateway_info: module stabilization #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
integration
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
4 times, most recently
from
790de8b
to
1ba6c6c
Compare
alinabuzachis
changed the title
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
from
1ba6c6c
to
b17f9d7
Compare
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
4 times, most recently
from
6034b59
to
4383fc9
Compare
alinabuzachis
changed the title
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
from
4383fc9
to
f866457
Compare
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
2 times, most recently
from
48f87e2
to
1551011
Compare
alinabuzachis
changed the title
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
2 times, most recently
from
2d23cb1
to
53d0b73
Compare
alinabuzachis
changed the title
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
from
53d0b73
to
05988db
Compare
jillr
reviewed
Mar 15, 2021
There was a problem hiding this comment.
2 small notes otherwise this looks really good. Thanks @alinabuzachis!
| @@ -122,7 +196,7 @@ def get_nat_gateways(client, module, nat_gateway_id=None): | |||
| def main(): | |||
| argument_spec = dict( | |||
| filters=dict(default={}, type='dict'), | |||
| nat_gateway_ids=dict(default=[], type='list', elements='str'), | |||
| nat_gateway_ids=dict(default=[], type='list', elements='str') | |||
There was a problem hiding this comment.
Please keep the trailing comma here. By having a comma already on the last item in this dict, the next time someone adds an option to the module they won't have to add it to this line which reduces the number of lines in the diff when someone reviews it.
There was a problem hiding this comment.
@jillr Thank you for reviewing. I added the trailing comma.
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
3 times, most recently
from
d857003
to
500be22
Compare
* Catches and handles (botocore.exceptions.BotoCoreError, botocore.exceptions.ClientError) on boto API calls * Add paginator * Document returned data Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
cleanup_nat_gw_info
branch
from
8f974e0
to
7a01a0a
Compare
jillr
approved these changes
Mar 18, 2021
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
* ec2_vpc_nat_gateway_info: stability * Catches and handles (botocore.exceptions.BotoCoreError, botocore.exceptions.ClientError) on boto API calls * Add paginator * Document returned data Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…lections#472) * ec2_vpc_nat_gateway_info: stability * Catches and handles (botocore.exceptions.BotoCoreError, botocore.exceptions.ClientError) on boto API calls * Add paginator * Document returned data Signed-off-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@b0f438b
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* ec2_vpc_nat_gateway_info: stability * Catches and handles (botocore.exceptions.BotoCoreError, botocore.exceptions.ClientError) on boto API calls * Add paginator * Document returned data Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* ec2_vpc_nat_gateway_info: stability * Catches and handles (botocore.exceptions.BotoCoreError, botocore.exceptions.ClientError) on boto API calls * Add paginator * Document returned data Signed-off-by: Alina Buzachis <[email protected]>
1 task
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* ec2_vpc_nat_gateway_info: stability * Catches and handles (botocore.exceptions.BotoCoreError, botocore.exceptions.ClientError) on boto API calls * Add paginator * Document returned data Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* ec2_vpc_nat_gateway_info: stability * Catches and handles (botocore.exceptions.BotoCoreError, botocore.exceptions.ClientError) on boto API calls * Add paginator * Document returned data Signed-off-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@b0f438b
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
aws_secret: Handle pagination for bypath=true Depends-On: ansible/ansible-zuul-jobs#1359 Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task. Fixes ansible-collections#472. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ec2_vpc_nat_gateway_info module stabilization and cleanup
COMPONENT NAME
ADDITIONAL INFORMATION
ec2_vpc_nat_gateway_info