fix KeyError: 'Tags' for ec2_instance #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
|
recheck |
ansibullbot
added
community_review
and removed
needs_revision
|
recheck |
|
We rely on the Name tag for tests, so we can't easily test this in CI, but the existing tests aren't failing. We've a few full test runs currently going through so I'll get this merged once the test queue is cleared. |
|
Thanks for the PR |
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
* fix key error when ec2 instance has no tags * add changelog fragment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* fix key error when ec2 instance has no tags * add changelog fragment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* fix key error when ec2 instance has no tags * add changelog fragment
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* fix key error when ec2 instance has no tags * add changelog fragment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* fix key error when ec2 instance has no tags * add changelog fragment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…collections#690) ec2_vpc_route_table - support associating internet gateways Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Update ec2_vpc_route_table to support associating internet gateways per feature request ansible-collections#476 Add integration tests Fix idempotency issue when associating a subnet with a route table ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Mark Woolley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When you apply
ec2_instanceon existing ec2 instances that has no tags,ec2_instancethrows key errors on 'Tags'.ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION