-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix target group remove / add logic #493
Conversation
/rebuild |
Not sure how to get the tests to re-run - the test failures seem to be issues pulling a docker image. |
Test was failing with a linting issue:
|
@jillr any chance you could try the ASG tests locally my connection's currently too flakey for the slow ASG tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes generally look good, unfortunately I'm not able to run the ASG tests for the next week or two (they're disabled in CI due to their very long duration).
Add additional integration tests to test linking target groups to autoscaling groups. Add changelog
ready_for_review |
Successfully run the local tests |
@msven, many thanks for your submission. This fix should be available in the next release of this collection (1.5.0) |
Fix target group remove / add logic Reviewed-by: Mark Chappell https://github.com/tremble This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@63769d5
Fix target group remove / add logic Reviewed-by: Mark Chappell https://github.com/tremble
Fix target group remove / add logic Reviewed-by: Mark Chappell https://github.com/tremble
SUMMARY
Fixes target group update logic to support updating target groups when the final number
of target groups attached to the asg remains the same.
Fixes #492
ISSUE TYPE
COMPONENT NAME
ec2_asg
ADDITIONAL INFORMATION
Integration tests were added to validate the change. The following test would've previously failed the final assertion.