rds_instance - test fixups #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alinabuzachis since you're working on #500 could you take a look at this PR I tried running the tests (without your changes) locally and had various failures |
ansibullbot
added
bug
@tremble Yes, sure! Thank you. |
ansibullbot
added
needs_revision
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* rds_instance - fix test syntax - test_read_replica.yml * Note that rds_instance tests are slow * add rds_snapshot to aws group * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* rds_instance - fix test syntax - test_read_replica.yml * Note that rds_instance tests are slow * add rds_snapshot to aws group * changelog
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* rds_instance - fix test syntax - test_read_replica.yml * Note that rds_instance tests are slow * add rds_snapshot to aws group * changelog
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Doc fix ec2_vol_info
SUMMARY
attachment_set has always be returned as a list of dictionaries, but the module documented it as a dictionary instead. Let's fix this documentation mismatch.
"attachment_set": [{
"attach_time": "2015-10-23T00:22:29.000Z",
"deleteOnTermination": "false",
"device": "/dev/sdf",
"instance_id": "i-8356263c",
"status": "attached"
}]
Fixes: ansible-collections#515
ISSUE TYPE
Docs Pull Request
COMPONENT NAME
ec2_vol_info
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* rds_instance - fix test syntax - test_read_replica.yml * Note that rds_instance tests are slow * add rds_snapshot to aws group * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@1722d02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The rds_instance tests are currenlty broken
ISSUE TYPE
COMPONENT NAME
rds_instance
rds_snapshot
ADDITIONAL INFORMATION