-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #343 for missing AWS_SESSION_TOKEN #535
Conversation
Thanks for taking the time to raise this PR. Please add a changelog fragment (https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to raise this PR.
The change looks sound. For some reason the aws_ssm tests aren't being run in our CI environment right now, so I'm running them locally. If they pass I'll get this merged.
Tests passing locally |
…ble-collections#535) * fix issue ansible-collections#343 for missing AWS_SESSION_TOKEN
…ble-collections#535) * fix issue ansible-collections#343 for missing AWS_SESSION_TOKEN
…ble-collections#535) * fix issue ansible-collections#343 for missing AWS_SESSION_TOKEN
…ollections#621) Add option to prefix and/or suffix hostvar coming from AWS SUMMARY Closes ansible-collections#535 ISSUE TYPE Feature Pull Request COMPONENT NAME Inventory plugins aws_ec2 aws_rds Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
SUMMARY
Fix logic to enable ssm connection if there is no AWS_SESSION_TOKEN
Fixes #343
ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION