Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #343 for missing AWS_SESSION_TOKEN #535

Merged
merged 6 commits into from
Apr 9, 2021

Conversation

ru-rocker
Copy link
Contributor

@ru-rocker ru-rocker commented Apr 9, 2021

SUMMARY

Fix logic to enable ssm connection if there is no AWS_SESSION_TOKEN

Fixes #343

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_ssm

ADDITIONAL INFORMATION

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review connection connection plugin needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Apr 9, 2021
@tremble
Copy link
Contributor

tremble commented Apr 9, 2021

Thanks for taking the time to raise this PR.

Please add a changelog fragment (https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to).

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Apr 9, 2021
CHANGELOG.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to raise this PR.

The change looks sound. For some reason the aws_ssm tests aren't being run in our CI environment right now, so I'm running them locally. If they pass I'll get this merged.

@tremble
Copy link
Contributor

tremble commented Apr 9, 2021

Tests passing locally

@tremble tremble merged commit 8b9ee85 into ansible-collections:main Apr 9, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…ollections#621)

Add option to prefix and/or suffix hostvar coming from AWS

SUMMARY

Closes ansible-collections#535

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

Inventory plugins
aws_ec2
aws_rds

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review connection connection plugin needs_triage new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot connect to ec2 instance via aws_ssm if AWS_SESSION_TOKEN is missing
3 participants