Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds_subnet_group: Add tags feature and enable check_mode #562

Merged
merged 11 commits into from
Mar 29, 2022
Merged

rds_subnet_group: Add tags feature and enable check_mode #562

merged 11 commits into from
Mar 29, 2022

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Apr 30, 2021 •
edited
Loading

SUMMARY

rds_subnet_group: Add tags feature and enable check_mode

Fixes: #552

Depends-On: ansible-collections/amazon.aws#553

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_subnet_group

@alinabuzachis alinabuzachis force-pushed the rds_subnet_tagging branch 5 times, most recently from 56c342f to c3b896d Compare May 5, 2021 15:27
@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis alinabuzachis requested a review from tremble May 7, 2021 09:32
@alinabuzachis alinabuzachis requested a review from jillr May 20, 2021 15:43
@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @scottanderson42 @tastychutney @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jul 20, 2021
@jillr
Copy link
Collaborator

jillr commented Jul 27, 2021

recheck

@alinabuzachis
Copy link
Contributor Author

recheck

1 similar comment
@alinabuzachis
Copy link
Contributor Author

recheck

@jillr
Copy link
Collaborator

jillr commented Aug 24, 2021

recheck
(tests passed locally, but good to have a recent CI run)

tremble
tremble requested changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay

plugins/modules/rds_subnet_group.py Outdated Show resolved Hide resolved
plugins/modules/rds_subnet_group.py Outdated Show resolved Hide resolved
plugins/modules/rds_subnet_group.py Show resolved Hide resolved
tests/integration/targets/rds_subnet_group/tasks/tests.yml Show resolved Hide resolved
@alinabuzachis
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (third-party-check pipeline).

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (third-party-check pipeline).

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Mar 25, 2022
@markuman markuman added the backport-3 PR should be backported to the stable-3 branch label Mar 25, 2022
@alinabuzachis
rds_subnet_group: Add tags support and enable check_mode
9efc866 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
* Linting
893eddc 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
* Add changelog fragment
08ae523 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
* Minor fix: ensure tags are always showed
2cdcfca 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
* Add some more aws_retry
b8d1b4f 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
Fix version_added
2138e15 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
Apply suggestions
8839666 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
Use shared logic from module_utils
b94c443 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
Fix versione_added
f64ff11 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
Add version_added and add paginator
a142edd 
Signed-off-by: Alina Buzachis <[email protected]>
@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

tremble
tremble approved these changes Mar 29, 2022
View reviewed changes
plugins/modules/rds_subnet_group.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Mar 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ce599bd into ansible-collections:main Mar 29, 2022
@patchback
Copy link

patchback bot commented Mar 29, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/ce599bdf68bbd05b23ac4ed6cc46ae37208c698c/pr-562

Backported as #1029

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2022
@alinabuzachis @patchback
rds_subnet_group: Add tags feature and enable check_mode (#562)
91ee957 
rds_subnet_group: Add tags feature and enable check_mode

SUMMARY

rds_subnet_group: Add tags feature and enable check_mode
Fixes: #552

Depends-On: ansible-collections/amazon.aws#553
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

rds_subnet_group

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit ce599bd)
@patchback patchback bot mentioned this pull request Mar 29, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 29, 2022
@patchback
rds_subnet_group: Add tags feature and enable check_mode (#562) (#1029)
86cc925 
[PR #562/ce599bdf backport][stable-3] rds_subnet_group: Add tags feature and enable check_mode

This is a backport of PR #562 as merged into main (ce599bd).
SUMMARY

rds_subnet_group: Add tags feature and enable check_mode
Fixes: #552

Depends-On: ansible-collections/amazon.aws#553
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

rds_subnet_group

Reviewed-by: Mark Woolley <[email protected]>
@renovate renovate bot mentioned this pull request Apr 6, 2022
Merged
1 task
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@alinabuzachis @goneri
rds_subnet_group: Add tags feature and enable check_mode (ansible-col…
8db7a9a 
…lections#562)

rds_subnet_group: Add tags feature and enable check_mode

SUMMARY

rds_subnet_group: Add tags feature and enable check_mode
Fixes: ansible-collections#552

Depends-On: ansible-collections/amazon.aws#553
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

rds_subnet_group

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@ce599bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknet15 marknet15 marknet15 approved these changes

@jillr jillr jillr approved these changes

@markuman markuman markuman approved these changes

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
backport-3 PR should be backported to the stable-3 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RDS Subnet Group Module does not manages tagging the resource
6 participants
@alinabuzachis @ansibullbot @jillr @tremble @markuman @marknet15