Cleanup ec2_elb* #586
Merged
Cleanup ec2_elb* #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
|
This issue helped me understand the history so leaving it here for anyone else who comes across this PR: Thanks for untangling this @tremble |
jillr
reviewed
Jun 1, 2021
tremble
force-pushed
the
cleanup/elb
branch
3 times, most recently
from
e8a23ee
to
82bb850
Compare
jillr
approved these changes
Jul 7, 2021
|
@tremble I'm +1 to gate this once the merge conflicts are resolved, thanks! |
ansibullbot
added
shipit
community_review
tests
tremble
force-pushed
the
cleanup/elb
branch
2 times, most recently
from
1b77ac6
to
cd92b12
Compare
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 15, 2021
…anup/elb Cleanup ec2_elb* SUMMARY This effectively reverts ansible/ansible#30532 @wimnat originally tried to keep ec2_elb, ec2_elb_lb and their fact/info partners separate from elb_instance / elb_classic_lb so that when a boto3 migration was performed the API/return values could be changed. We no longer have a 'preview' flag on the interface, so this is just causing duplication. ec2_elb_info now has a boto3 based equivalent elb_classic_lb_info deprecate it so we can drop the old boto based module elb_classic_lb was never rewritten, point it at amazon.aws.ec2_elb_lb so we only try and do the boto3 migration in one place elb_instance was never rewritten, point ec2_elb at community.aws.elb_instance so we only try and do the boto3 migration in one place Before we release 2.0.0 let's get this back to something vaguely consistent. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_elb ec2_elb_lb ec2_elb_info elb_classic_lb elb_classic_lb_info ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@aaa1327
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…anup/elb Cleanup ec2_elb* SUMMARY This effectively reverts ansible/ansible#30532 @wimnat originally tried to keep ec2_elb, ec2_elb_lb and their fact/info partners separate from elb_instance / elb_classic_lb so that when a boto3 migration was performed the API/return values could be changed. We no longer have a 'preview' flag on the interface, so this is just causing duplication. ec2_elb_info now has a boto3 based equivalent elb_classic_lb_info deprecate it so we can drop the old boto based module elb_classic_lb was never rewritten, point it at amazon.aws.ec2_elb_lb so we only try and do the boto3 migration in one place elb_instance was never rewritten, point ec2_elb at community.aws.elb_instance so we only try and do the boto3 migration in one place Before we release 2.0.0 let's get this back to something vaguely consistent. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_elb ec2_elb_lb ec2_elb_info elb_classic_lb elb_classic_lb_info ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@aaa1327
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 17, 2021
…anup/elb Cleanup ec2_elb* SUMMARY This effectively reverts ansible/ansible#30532 @wimnat originally tried to keep ec2_elb, ec2_elb_lb and their fact/info partners separate from elb_instance / elb_classic_lb so that when a boto3 migration was performed the API/return values could be changed. We no longer have a 'preview' flag on the interface, so this is just causing duplication. ec2_elb_info now has a boto3 based equivalent elb_classic_lb_info deprecate it so we can drop the old boto based module elb_classic_lb was never rewritten, point it at amazon.aws.ec2_elb_lb so we only try and do the boto3 migration in one place elb_instance was never rewritten, point ec2_elb at community.aws.elb_instance so we only try and do the boto3 migration in one place Before we release 2.0.0 let's get this back to something vaguely consistent. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_elb ec2_elb_lb ec2_elb_info elb_classic_lb elb_classic_lb_info ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@b946932
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Cleanup ec2_elb* SUMMARY This effectively reverts ansible/ansible#30532 @wimnat originally tried to keep ec2_elb, ec2_elb_lb and their fact/info partners separate from elb_instance / elb_classic_lb so that when a boto3 migration was performed the API/return values could be changed. We no longer have a 'preview' flag on the interface, so this is just causing duplication. ec2_elb_info now has a boto3 based equivalent elb_classic_lb_info deprecate it so we can drop the old boto based module elb_classic_lb was never rewritten, point it at amazon.aws.ec2_elb_lb so we only try and do the boto3 migration in one place elb_instance was never rewritten, point ec2_elb at community.aws.elb_instance so we only try and do the boto3 migration in one place Before we release 2.0.0 let's get this back to something vaguely consistent. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_elb ec2_elb_lb ec2_elb_info elb_classic_lb elb_classic_lb_info ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Cleanup ec2_elb* SUMMARY This effectively reverts ansible/ansible#30532 @wimnat originally tried to keep ec2_elb, ec2_elb_lb and their fact/info partners separate from elb_instance / elb_classic_lb so that when a boto3 migration was performed the API/return values could be changed. We no longer have a 'preview' flag on the interface, so this is just causing duplication. ec2_elb_info now has a boto3 based equivalent elb_classic_lb_info deprecate it so we can drop the old boto based module elb_classic_lb was never rewritten, point it at amazon.aws.ec2_elb_lb so we only try and do the boto3 migration in one place elb_instance was never rewritten, point ec2_elb at community.aws.elb_instance so we only try and do the boto3 migration in one place Before we release 2.0.0 let's get this back to something vaguely consistent. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_elb ec2_elb_lb ec2_elb_info elb_classic_lb elb_classic_lb_info ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Cleanup ec2_elb* SUMMARY This effectively reverts ansible/ansible#30532 @wimnat originally tried to keep ec2_elb, ec2_elb_lb and their fact/info partners separate from elb_instance / elb_classic_lb so that when a boto3 migration was performed the API/return values could be changed. We no longer have a 'preview' flag on the interface, so this is just causing duplication. ec2_elb_info now has a boto3 based equivalent elb_classic_lb_info deprecate it so we can drop the old boto based module elb_classic_lb was never rewritten, point it at amazon.aws.ec2_elb_lb so we only try and do the boto3 migration in one place elb_instance was never rewritten, point ec2_elb at community.aws.elb_instance so we only try and do the boto3 migration in one place Before we release 2.0.0 let's get this back to something vaguely consistent. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_elb ec2_elb_lb ec2_elb_info elb_classic_lb elb_classic_lb_info ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This effectively reverts ansible/ansible#30532
@wimnat originally tried to keep ec2_elb, ec2_elb_lb and their fact/info partners separate from elb_instance / elb_classic_lb so that when a boto3 migration was performed the API/return values could be changed. We no longer have a 'preview' flag on the interface, so this is just causing duplication.
Before we release 2.0.0 let's get this back to something vaguely consistent.
ISSUE TYPE
COMPONENT NAME
ec2_elb
ec2_elb_lb
ec2_elb_info
elb_classic_lb
elb_classic_lb_info
ADDITIONAL INFORMATION