Add support for SQS RawMessageDelievery attribute in subscriptions - issue #193 #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
jillr
reviewed
Jul 15, 2021
|
recheck |
|
@alinabuzachis @jillr can you review the PR please? |
tremble
requested changes
Aug 25, 2021
tremble
requested changes
Oct 28, 2021
…or RawMessageDelievery (SQS) Add sqs subscription for testing
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jul 3, 2022
|
Sorry it's taken so long to get back to this review. I've rebased this against the latest change sets and I think it's ready to be merged |
tremble
added
mergeit
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1302 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 3, 2022
…or RawMessageDelievery (SQS) (#640) Add support for SQS RawMessageDelievery attribute in subscriptions - issue #193 SUMMARY Added support to configure RawMessageDelievery option when configuring sqs endpoints. It use boto3 set_subscription_attributes() to configure changes. It currently supports only this option, but should be easily extended in the future. Attributes are expected in the form as in the boto3 docs: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sns.html#SNS.Client.set_subscription_attributes Fixes #193 ISSUE TYPE Feature Pull Request COMPONENT NAME updates sns_topic.py to support new functionality example: - sns_topic: name: '{{ sns_topic_topic_name }}' display_name: My new topic name subscriptions: - endpoint: "{{ sqs_arn }}" protocol: sqs attributes: RawMessageDelivery: true Reviewed-by: Jill R <None> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 932263d)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 3, 2022
…or RawMessageDelievery (SQS) (#640) (#1302) [PR #640/932263d4 backport][stable-4] Add support for SQS RawMessageDelievery attribute in subscriptions - issue #193 This is a backport of PR #640 as merged into main (932263d). SUMMARY Added support to configure RawMessageDelievery option when configuring sqs endpoints. It use boto3 set_subscription_attributes() to configure changes. It currently supports only this option, but should be easily extended in the future. Attributes are expected in the form as in the boto3 docs: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sns.html#SNS.Client.set_subscription_attributes Fixes #193 ISSUE TYPE Feature Pull Request COMPONENT NAME updates sns_topic.py to support new functionality example: - sns_topic: name: '{{ sns_topic_topic_name }}' display_name: My new topic name subscriptions: - endpoint: "{{ sqs_arn }}" protocol: sqs attributes: RawMessageDelivery: true Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
sns_topic - Fix Permission Issue for Cross Account Subscriptions SUMMARY sns_topic currently fails with the following error if it has any cross account subscriptions: Couldn't get subscription attributes for subscription arn:aws:sns:us-east-1:123412341234:my-sns-topic-name:555950dc-7c5f-416c-8f8e-e8f38eabfa54: An error occurred (AuthorizationError) when calling the GetSubscriptionAttributes operation: Not authorized to access this subscription This happens, for example, when a Lambda function in account A is subscribed to an SNS topic in account B, as described here. I believe this was caused by #640. I am not sure how to write a test for this specific situation as it would require multiple AWS accounts. ISSUE TYPE Bugfix Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION - community.aws.sns_topic: name: my-sns-topic-in-account-123412341234 subscriptions: - endpoint: "arn:aws:lambda:us-east-1:567856785678:function:my-lambda-function-in-account-567856785678" protocol: lambda state: present Reviewed-by: Mark Chappell <None>
patchback bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
sns_topic - Fix Permission Issue for Cross Account Subscriptions SUMMARY sns_topic currently fails with the following error if it has any cross account subscriptions: Couldn't get subscription attributes for subscription arn:aws:sns:us-east-1:123412341234:my-sns-topic-name:555950dc-7c5f-416c-8f8e-e8f38eabfa54: An error occurred (AuthorizationError) when calling the GetSubscriptionAttributes operation: Not authorized to access this subscription This happens, for example, when a Lambda function in account A is subscribed to an SNS topic in account B, as described here. I believe this was caused by #640. I am not sure how to write a test for this specific situation as it would require multiple AWS accounts. ISSUE TYPE Bugfix Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION - community.aws.sns_topic: name: my-sns-topic-in-account-123412341234 subscriptions: - endpoint: "arn:aws:lambda:us-east-1:567856785678:function:my-lambda-function-in-account-567856785678" protocol: lambda state: present Reviewed-by: Mark Chappell <None> (cherry picked from commit de21c4b)
patchback bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
sns_topic - Fix Permission Issue for Cross Account Subscriptions SUMMARY sns_topic currently fails with the following error if it has any cross account subscriptions: Couldn't get subscription attributes for subscription arn:aws:sns:us-east-1:123412341234:my-sns-topic-name:555950dc-7c5f-416c-8f8e-e8f38eabfa54: An error occurred (AuthorizationError) when calling the GetSubscriptionAttributes operation: Not authorized to access this subscription This happens, for example, when a Lambda function in account A is subscribed to an SNS topic in account B, as described here. I believe this was caused by #640. I am not sure how to write a test for this specific situation as it would require multiple AWS accounts. ISSUE TYPE Bugfix Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION - community.aws.sns_topic: name: my-sns-topic-in-account-123412341234 subscriptions: - endpoint: "arn:aws:lambda:us-east-1:567856785678:function:my-lambda-function-in-account-567856785678" protocol: lambda state: present Reviewed-by: Mark Chappell <None> (cherry picked from commit de21c4b)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
…) (#1700) [PR #1418/de21c4bd backport][stable-4] sns_topic - Fix Permission Issue for Cross Account Subscriptions This is a backport of PR #1418 as merged into main (de21c4b). SUMMARY sns_topic currently fails with the following error if it has any cross account subscriptions: Couldn't get subscription attributes for subscription arn:aws:sns:us-east-1:123412341234:my-sns-topic-name:555950dc-7c5f-416c-8f8e-e8f38eabfa54: An error occurred (AuthorizationError) when calling the GetSubscriptionAttributes operation: Not authorized to access this subscription This happens, for example, when a Lambda function in account A is subscribed to an SNS topic in account B, as described here. I believe this was caused by #640. I am not sure how to write a test for this specific situation as it would require multiple AWS accounts. ISSUE TYPE Bugfix Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION - community.aws.sns_topic: name: my-sns-topic-in-account-123412341234 subscriptions: - endpoint: "arn:aws:lambda:us-east-1:567856785678:function:my-lambda-function-in-account-567856785678" protocol: lambda state: present Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
…) (#1701) [PR #1418/de21c4bd backport][stable-5] sns_topic - Fix Permission Issue for Cross Account Subscriptions This is a backport of PR #1418 as merged into main (de21c4b). SUMMARY sns_topic currently fails with the following error if it has any cross account subscriptions: Couldn't get subscription attributes for subscription arn:aws:sns:us-east-1:123412341234:my-sns-topic-name:555950dc-7c5f-416c-8f8e-e8f38eabfa54: An error occurred (AuthorizationError) when calling the GetSubscriptionAttributes operation: Not authorized to access this subscription This happens, for example, when a Lambda function in account A is subscribed to an SNS topic in account B, as described here. I believe this was caused by #640. I am not sure how to write a test for this specific situation as it would require multiple AWS accounts. ISSUE TYPE Bugfix Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION - community.aws.sns_topic: name: my-sns-topic-in-account-123412341234 subscriptions: - endpoint: "arn:aws:lambda:us-east-1:567856785678:function:my-lambda-function-in-account-567856785678" protocol: lambda state: present Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support to configure
RawMessageDelieveryoption when configuring sqs endpoints.It use boto3
set_subscription_attributes()to configure changes.It currently supports only this option, but should be easily extended in the future.
Attributes are expected in the form as in the boto3 docs:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sns.html#SNS.Client.set_subscription_attributes
Fixes #193
ISSUE TYPE
COMPONENT NAME
updates sns_topic.py to support new functionality