[Plugin elasticache_info] includes the description of each replication group #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
|
Should I also includes my name as one of the author of this module ? |
|
Sanity is failing You can run sanity checks easy locally before pushing, see https://docs.ansible.com/ansible/latest/dev_guide/testing_sanity.html#testing-sanity Furthermore it would be good when you verify the extended output in the integration test.
Feel free, A contribution is a contribution, and every contribution is valueable! |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…e-collections#646) Handle ResourceNotFoundException while iterating certificates SUMMARY The module/utils/acm.py was not correctly handling deletion of certificates. While iterating over a list of certificates, the get_certificate function was making API calls to obtain more information about the certificates, but some certificates may be deleted while iterating. Fixes ansible-collections#622 ISSUE TYPE Bugfix Pull Request COMPONENT NAME acm.py ADDITIONAL INFORMATION Wow, it seems many tests are very flaky. I'm attempting to fix an issue in ACM, but problems occur elsewhere. Not to mention I raised this PR to fix ansible-collections#622, which was discovered while working on ansible-collections#870. And I discovered other issues as well, and so it looks like it's not possible to make any progress without going down a tree of bug fixes. TypeError: 'NoneType' object is not subscriptable fatal: [testhost]: FAILED! => { "changed": false, "module_stderr": "Traceback (most recent call last):\n File \"<stdin>\", line 121, in <module>\n File \"<stdin>\", line 113, in _ansiballz_main\n File \"<stdin>\", line 61, in invoke_module\n File \"/usr/lib64/python3.8/runpy.py\", line 207, in run_module\n return _run_module_code(code, init_globals, run_name, mod_spec)\n File \"/usr/lib64/python3.8/runpy.py\", line 97, in _run_module_code\n _run_code(code, mod_globals, init_globals,\n File \"/usr/lib64/python3.8/runpy.py\", line 87, in _run_code\n exec(code, run_globals)\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 248, in <module>\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 242, in main\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 132, in process\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 220, in ensure_igw_present\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 158, in get_igw_info\nTypeError: 'NoneType' object is not subscriptable\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1 } Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
tremble
force-pushed
the
elasticache_info_fetch_replication_group_info
branch
from
2bc526b
to
a2af0b8
Compare
tremble
force-pushed
the
elasticache_info_fetch_replication_group_info
branch
from
437d96f
to
5aaa42d
Compare
|
I've rebased and added some minimal integration tests. We don't currently support managing the replication so testing's pretty minimal, but is at least there. |
tremble
force-pushed
the
elasticache_info_fetch_replication_group_info
branch
from
5aaa42d
to
c1aa1c2
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jul 1, 2022
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1292 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…n group (#646) [Plugin elasticache_info] includes the description of each replication group SUMMARY This pull request add the description of the corresponding Elasticache replication group into each described cache cluster. ISSUE TYPE Feature Pull Request COMPONENT NAME elasticache_info ADDITIONAL INFORMATION Actually the only way to describe Elasticache replication groups with Ansible is to use the dynamic inventory. However, exposing the informations about each replication group could be useful in other contexts. In my case, I am generating a few .env files and I need to include some Elasticache replication group primary endpoint and reader endpoint. Since the elasticache_info plugin already exist and already retrieves the appropriate replication_group_id, I believe that this plugin should also retrieve the replication group description when it exists. OTHER REMARKS CONCERNING THIS PULL REQUEST Each provided description is copy/pasted from the official boto3 documentation which is distributed under an Apache 2.0 licence. I did it for consistency reason between and also because I am not a native speaker. Also the provided description is incomplete : I only documented the fields that I was able to retrieve from my current AWS clusters. Boto3 documentation of the "describe_replication_groups" function : https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elasticache.html#ElastiCache.Client.describe_replication_groups Moreover this pull request might violates the "integration tests" rule : I didn't find any integration test for the elasticache_info plugin and I don't know why no integration test have been made. Reviewed-by: Mark Chappell <None> (cherry picked from commit d7e3617)
|
Thanks for your submission, I'm sorry it's taken so long to get this merged. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…n group (#646) (#1292) [PR #646/d7e36178 backport][stable-4] [Plugin elasticache_info] includes the description of each replication group This is a backport of PR #646 as merged into main (d7e3617). SUMMARY This pull request add the description of the corresponding Elasticache replication group into each described cache cluster. ISSUE TYPE Feature Pull Request COMPONENT NAME elasticache_info ADDITIONAL INFORMATION Actually the only way to describe Elasticache replication groups with Ansible is to use the dynamic inventory. However, exposing the informations about each replication group could be useful in other contexts. In my case, I am generating a few .env files and I need to include some Elasticache replication group primary endpoint and reader endpoint. Since the elasticache_info plugin already exist and already retrieves the appropriate replication_group_id, I believe that this plugin should also retrieve the replication group description when it exists. OTHER REMARKS CONCERNING THIS PULL REQUEST Each provided description is copy/pasted from the official boto3 documentation which is distributed under an Apache 2.0 licence. I did it for consistency reason between and also because I am not a native speaker. Also the provided description is incomplete : I only documented the fields that I was able to retrieve from my current AWS clusters. Boto3 documentation of the "describe_replication_groups" function : https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elasticache.html#ElastiCache.Client.describe_replication_groups Moreover this pull request might violates the "integration tests" rule : I didn't find any integration test for the elasticache_info plugin and I don't know why no integration test have been made. Reviewed-by: Mark Chappell <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request add the description of the corresponding Elasticache replication group into each described cache cluster.
ISSUE TYPE
COMPONENT NAME
elasticache_info
ADDITIONAL INFORMATION
Actually the only way to describe Elasticache replication groups with Ansible is to use the dynamic inventory.
However, exposing the informations about each replication group could be useful in other contexts.
In my case, I am generating a few .env files and I need to include some Elasticache replication group primary endpoint and reader endpoint.
Since the elasticache_info plugin already exist and already retrieves the appropriate replication_group_id, I believe that this plugin should also retrieve the replication group description when it exists.
OTHER REMARKS CONCERNING THIS PULL REQUEST
Each provided description is copy/pasted from the official boto3 documentation which is distributed under an Apache 2.0 licence. I did it for consistency reason between and also because I am not a native speaker.
Also the provided description is incomplete : I only documented the fields that I was able to retrieve from my current AWS clusters.
Boto3 documentation of the "describe_replication_groups" function : https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elasticache.html#ElastiCache.Client.describe_replication_groups
Moreover this pull request might violates the "integration tests" rule : I didn't find any integration test for the elasticache_info plugin and I don't know why no integration test have been made.