Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keys_attr parameter to aws_kms_info #648

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Add keys_attr parameter to aws_kms_info #648

merged 1 commit into from
Aug 10, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 19, 2021

SUMMARY

Move the kms_info return value from "keys" (which conflicts with keys()) to kms_keys. Add a parameter to support the old version

Fixes #597

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_kms_info

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jul 19, 2021
markuman
markuman reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A changelog fragment is missing. otherwise lgtm

@tremble tremble requested a review from markuman August 10, 2021 07:34
markuman
markuman approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tremble tremble added the gate label Aug 10, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 68f87ef into ansible-collections:main Aug 10, 2021
@tremble tremble deleted the kms_info/keys branch November 26, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_kms_info keys attribute returns builtin keys method
3 participants
@tremble @ansibullbot @markuman