Cleanup boto3/botocore dependencies - remove tests for unsupported versions #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
force-pushed
the
boto3/minimums
branch
2 times, most recently
from
8c9cb32
to
fbfa8f0
Compare
|
recheck |
The relevant method definitions live (as data files) in botocore. boto3 -> botocore version mapping is unreliable.
tremble
force-pushed
the
boto3/minimums
branch
from
fbc6948
to
17e8577
Compare
|
@tremble This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
ansibullbot
added
needs_rebase
alinabuzachis
approved these changes
Aug 10, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
Merged
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…_contrib_script_compatible_ec2_tag_keys (ansible-collections#858) Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added ansible-collections#328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added ansible-collections#331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one ansible-collections#676 and ansible-collections#675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Testing for boto3/botocore support on specific functions is very inconsistent. Now that we have minimum supported versions we can drop the tests for previous versions.
ISSUE TYPE
COMPONENT NAME
plugins/modules/aws_eks_cluster.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_msk_config.py
plugins/modules/cloudformation_stack_set.py
plugins/modules/dynamodb_table.py
plugins/modules/dynamodb_ttl.py
plugins/modules/ec2_ami_copy.py
plugins/modules/ec2_asg.py
plugins/modules/ec2_launch_template.py
plugins/modules/ec2_transit_gateway.py
plugins/modules/ec2_transit_gateway_info.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/ecs_ecr.py
plugins/modules/ecs_service.py
plugins/modules/ecs_task.py
plugins/modules/ecs_taskdefinition.py
plugins/modules/efs.py
plugins/modules/efs_info.py
plugins/modules/elb_target_group.py
plugins/modules/iam_role.py
plugins/modules/lambda.py
plugins/modules/rds_instance.py
plugins/modules/sqs_queue.py
ADDITIONAL INFORMATION
Depends-on: ansible-collections/amazon.aws#442
Depends-on: ansible-collections/amazon.aws#446